-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use file based OLM catalog #56
Conversation
.github/workflows/release.yaml
Outdated
branches: | ||
- main | ||
tags: | ||
- "v*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
Right now it was pretty easy as documented at https://github.com/3scale-ops/prometheus-exporter-operator/blob/main/docs/release.md#stable, you dont need to add any manual tag
..., you change the bundle files... and if the GH action detect there is a change on the version, execute the release process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release file has been removed, will be implemented in the next PR as discussed internally.
ec94e95
to
0f954cd
Compare
Signed-off-by: Rael Garcia Arnes <rael@redhat.com>
0f954cd
to
068e8aa
Compare
LGTM label has been added. Git tree hash: 638052fedc306905c33085ccdc36528eac3efc72
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raelga The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request includes significant changes to the GitHub Actions workflow and the Makefile for the
prometheus-exporter-operator
project. The changes primarily focus on improving the release process, containerization, and metadata management.GitHub Actions Workflow Improvements:
v*
instead of branches. (.github/workflows/release.yaml
).github/workflows/release.yaml
)Makefile Enhancements:
Makefile
)docker-build
anddocker-push
targets withcontainer-build
andcontainer-push
to support multiple architectures using Docker Buildx. (Makefile
)Makefile
)bundle-build
andbundle-push
targets to use the new container build process. (Makefile
)Makefile
)Metadata and Dockerfile Updates:
bundle.Dockerfile
,catalog/Dockerfile
) [1] [2]bundle/metadata/annotations.yaml
)File based OLM catalog
These changes collectively enhance the automation, compatibility, consistency, and reliability of the release process for the
prometheus-exporter-operator
project.Notes
/kind feature
/priority important-longterm
/assign