Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use file based OLM catalog #56

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat: use file based OLM catalog #56

merged 1 commit into from
Nov 15, 2024

Conversation

raelga
Copy link
Contributor

@raelga raelga commented Nov 15, 2024

This pull request includes significant changes to the GitHub Actions workflow and the Makefile for the prometheus-exporter-operator project. The changes primarily focus on improving the release process, containerization, and metadata management.

GitHub Actions Workflow Improvements:

  • Updated the trigger for the release workflow to run on tags matching the pattern v* instead of branches. (.github/workflows/release.yaml)
  • Added steps to set up Docker metadata, QEMU, and Docker Buildx, and updated the build and push steps to use these new configurations, adding support for ARM64 and AMD64 architectures. (.github/workflows/release.yaml)

Makefile Enhancements:

  • Introduced environment variable handling for versioning when running in GitHub Actions. (Makefile)
  • Replaced docker-build and docker-push targets with container-build and container-push to support multiple architectures using Docker Buildx. (Makefile)
  • Added new targets for managing catalog entries and validating the catalog. (Makefile)
  • Updated the bundle-build and bundle-push targets to use the new container build process. (Makefile)
  • Improved bundle catalog manifest generation to inherit alpha and stable releases from $VERSION. Makefile)

Metadata and Dockerfile Updates:

  • Updated bundle and catalog Dockerfiles to align with the new build process and metadata requirements. (bundle.Dockerfile, catalog/Dockerfile) [1] [2]
  • Adjusted metadata annotations to reflect the new versioning and channel configurations. (bundle/metadata/annotations.yaml)

File based OLM catalog

These changes collectively enhance the automation, compatibility, consistency, and reliability of the release process for the prometheus-exporter-operator project.

Notes

/kind feature
/priority important-longterm
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. labels Nov 15, 2024
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/L Requires few days to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Nov 15, 2024
branches:
- main
tags:
- "v*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Right now it was pretty easy as documented at https://github.com/3scale-ops/prometheus-exporter-operator/blob/main/docs/release.md#stable, you dont need to add any manual tag
..., you change the bundle files... and if the GH action detect there is a change on the version, execute the release process

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release file has been removed, will be implemented in the next PR as discussed internally.

Signed-off-by: Rael Garcia Arnes <rael@redhat.com>
@3scale-robot 3scale-robot added size/M Requires about a day to complete the PR or the issue. and removed size/L Requires few days to complete the PR or the issue. labels Nov 15, 2024
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 638052fedc306905c33085ccdc36528eac3efc72

@raelga
Copy link
Contributor Author

raelga commented Nov 15, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@3scale-robot 3scale-robot merged commit c6a9dde into main Nov 15, 2024
2 checks passed
@3scale-robot 3scale-robot deleted the feat/file-based-olm branch November 15, 2024 10:31
@raelga raelga mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants