Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grafana-operator label selector from all examples to match default operator value #55

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

slopezz
Copy link
Member

@slopezz slopezz commented Nov 7, 2024

The example of grafana label selector used on different places (docs, CSV example, real examples, tests...) has been updated to match current default value of the operator.

Actually, previous label monitoring-key produces errors on grafana-operator v5.

/kind documentation
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. labels Nov 7, 2024
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Nov 7, 2024
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 04c1ad1ec34b5ba4e58e656f7d31cc2329ccd854

@slopezz
Copy link
Member Author

slopezz commented Nov 7, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@3scale-robot 3scale-robot merged commit 16a2da5 into main Nov 7, 2024
2 checks passed
@3scale-robot 3scale-robot deleted the feat/update-example-grafana-label branch November 7, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants