Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set target _blank for original post link #1280

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

gustavo-p-rossler
Copy link

Description of the Change

This PR updates the link for the original Post, that appears in the editor when the user is editing a pulled Post.
With the current behavior the link opens the original Post in the same window (or browser tab). With the change I made, the link opens the original Post in a new window.

Closes #1271

How to test the Change

This can be verfied by pulling and editing a Post.

Changelog Entry

Changed - Link to original Post

Credits

I was the only one working on this simple change.

Checklist:

@gustavo-p-rossler gustavo-p-rossler requested a review from a team as a code owner October 8, 2024 12:04
@gustavo-p-rossler gustavo-p-rossler requested review from peterwilsoncc and removed request for a team October 8, 2024 12:04
@jeffpaul jeffpaul added this to the 2.1.0 milestone Oct 8, 2024
@jeffpaul
Copy link
Member

jeffpaul commented Oct 8, 2024

@gustavo-p-rossler thanks for the PR on this, in order to make it more clear that it'll open in a new tab could you add the https://developer.wordpress.org/resource/dashicons/#external icon as part of that link (usually after the text with a space between the text and icon)?

@gustavo-p-rossler
Copy link
Author

gustavo-p-rossler commented Oct 8, 2024

@gustavo-p-rossler thanks for the PR on this, in order to make it more clear that it'll open in a new tab could you add the https://developer.wordpress.org/resource/dashicons/#external icon as part of that link (usually after the text with a space between the text and icon)?

Hi @jeffpaul, I've updated the PR adding the external icon as you can see in the screenshot bellow:

Screenshot 2024-10-08 at 18 05 25

@peterwilsoncc
Copy link
Collaborator

@gustavo-p-rossler Thanks for the pull request.

This tests well in the Gutenberg/Block editor but will need an equivalent change for the classic editor interface to add the icon and the targetting.

The code for the classic editor can be found in this block of code:

<span><a href="<?php echo esc_url( $original_post_url ); ?>">
<?php
printf(
/* translators: 1) Distributor post type singular name. */
esc_html__( 'View the origin %1$s.', 'distributor' ),
esc_html( strtolower( $post_type_singular ) )
);
?>
</a></span>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"View the Origin Post" opens as a new tab
3 participants