Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing css #1208

Merged
merged 3 commits into from
Apr 12, 2024
Merged

fix missing css #1208

merged 3 commits into from
Apr 12, 2024

Conversation

psorensen
Copy link
Contributor

Description of the Change

Fixes a missing script. The admin-settings.css and admin.css had identical IDs when be enqueued, causing the admin-settings.css not to load, thus breaking the Registration Key validity indicator.

Closes #1207

How to test the Change

  1. Visit Distributor -> Settings
  2. Enter a valid or invalid registration key and click save settings
  3. Observe the indicator icon next to the input displays
    image

Changelog Entry

Fixed - Missing admin script

Credits

Props @psorensen

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@psorensen psorensen requested a review from a team as a code owner March 21, 2024 19:25
@psorensen psorensen requested review from Sidsector9 and removed request for a team March 21, 2024 19:25
@github-actions github-actions bot added this to the 2.1.0 milestone Mar 21, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Mar 21, 2024
Updates the ID  of the admin-settings.css enqueue  as it was conflicting with the admin.css enqueue ID
@psorensen psorensen force-pushed the fix/registration-key-indicator branch from 4bbc608 to c1bb168 Compare March 21, 2024 19:27
@jeffpaul jeffpaul merged commit 514058b into develop Apr 12, 2024
13 of 17 checks passed
@jeffpaul jeffpaul deleted the fix/registration-key-indicator branch April 12, 2024 18:28
@dkotter dkotter modified the milestones: 2.1.0, 2.0.5 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration validity indicator not displaying
4 participants