-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #1184
Fix typos #1184
Conversation
@@ -1,6 +1,6 @@ | |||
# Dependency Review Action | |||
# | |||
# This Action will scan dependency manifest files that change as part of a Pull Reqest, surfacing known-vulnerable versions of the packages declared or updated in the PR. Once installed, if the workflow run is marked as required, PRs introducing known-vulnerable packages will be blocked from merging. | |||
# This Action will scan dependency manifest files that change as part of a Pull Request, surfacing known-vulnerable versions of the packages declared or updated in the PR. Once installed, if the workflow run is marked as required, PRs introducing known-vulnerable packages will be blocked from merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably exists across all our repos 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no!
😲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduce typos
to your organization.
@10up/open-source-practice tagging the team as there are some code-related typos that I'm not quickly certain aren't referenced elsewhere / might have implications in changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look fine to me, I've confirmed the registration key is retained with the settings change.
The one thought I have is to properly deprecate the function names as they're available externally so it's possible they are used elsewhere. I couldn't find anything on GitHub but as Distributor tends to be used by enterprise clients, often their repositories are private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @szepeviktor, this looks good to me.
I've taken the liberty of pushing a few coding standards fixes to your branch in d98248e and fixed a few more typos in 95d8118.
This looks good to me.
Glad to contribute. |
Description of the Change
Found few misspellings.
How to test the Change
Read the diff.
Checklist: