Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1184

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Fix typos #1184

merged 5 commits into from
Jan 21, 2024

Conversation

szepeviktor
Copy link
Contributor

Description of the Change

Found few misspellings.

How to test the Change

Read the diff.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@szepeviktor szepeviktor requested review from jeffpaul and a team as code owners January 18, 2024 21:15
@@ -1,6 +1,6 @@
# Dependency Review Action
#
# This Action will scan dependency manifest files that change as part of a Pull Reqest, surfacing known-vulnerable versions of the packages declared or updated in the PR. Once installed, if the workflow run is marked as required, PRs introducing known-vulnerable packages will be blocked from merging.
# This Action will scan dependency manifest files that change as part of a Pull Request, surfacing known-vulnerable versions of the packages declared or updated in the PR. Once installed, if the workflow run is marked as required, PRs introducing known-vulnerable packages will be blocked from merging.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably exists across all our repos 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no!

😲

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduce typos to your organization.

@jeffpaul jeffpaul requested a review from a team January 18, 2024 21:18
@jeffpaul jeffpaul added this to the 2.1.0 milestone Jan 18, 2024
@jeffpaul
Copy link
Member

@10up/open-source-practice tagging the team as there are some code-related typos that I'm not quickly certain aren't referenced elsewhere / might have implications in changing

Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine to me, I've confirmed the registration key is retained with the settings change.

The one thought I have is to properly deprecate the function names as they're available externally so it's possible they are used elsewhere. I couldn't find anything on GitHub but as Distributor tends to be used by enterprise clients, often their repositories are private.

includes/debug-info.php Show resolved Hide resolved
includes/settings.php Show resolved Hide resolved
Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szepeviktor, this looks good to me.

I've taken the liberty of pushing a few coding standards fixes to your branch in d98248e and fixed a few more typos in 95d8118.

This looks good to me.

@peterwilsoncc peterwilsoncc merged commit 0e5eab5 into 10up:develop Jan 21, 2024
14 of 15 checks passed
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor szepeviktor deleted the typos branch January 21, 2024 22:48
@dkotter dkotter modified the milestones: 2.1.0, 2.0.4 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants