-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 2.0.0 #1123
Release: 2.0.0 #1123
Conversation
E2E tests that are running on WP 6.3 are failing due to the change in 6.3 where the Block Editor is loaded in an iframe by default. Cypress won't load the contents of the iframe by default but you can get around this with a config value (which I added here). But in addition to that, any interaction that we do with the editor needs to account for the editor being in an iframe. For example, any use of |
@dkotter given the Migration guide for v1 > v2 is relatively light on need, but perhaps we should still call that out here in the CHANGELOG.md as another sentence linking to that guide for folks to reference in their upgrades? If its significant enough of a migration need, then we might also have an admin notice that references it perhaps? |
I've added links to the CHANGELOG and README files for that migration guide. I don't think it warrants an admin notice, especially since the few things we call out are more developer type things which an admin may not have the ability/access to do anything there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some other items in the v2 milestone, but nothing that I would fight people for to get into this release so approving this release PR as-is... very exciting!
For the migration guide, these are possible things we should call out:
|
@peterwilsoncc is there an update to the hookdocs page and the changelog that you could push up here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E tests failures are due to the iframed post editor (.block-editor-default-block-appender__content
exists but not in the DOM tree Cypress has access too).
In some Gutenberg tests for the PR iframing the post editor, a dummy block was created to prevent the iframe from being initiated. Perhaps we could do that but I don't think it's a blocker for release.
1d4d0f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove following change log update.
develop
, create a release branch namedrelease/2.0.0
for your changes.distributor.php
,package.json
,package-lock.json
,readme.txt
andtests/php/bootstrap.php
if it does not already reflect the version being released. Indistributor.php
update both the plugin "Version:" property and the pluginDT_VERSION
constant.webpack.config.release.js
.CHANGELOG.md
.CREDITS.md
file with any new contributors, confirm maintainers are accurate.README.md
is geared toward GitHub andreadme.txt
contains WordPress.org-specific content. The two are slightly different.@since
tags indicate the new version, replacingx.x.x
,n.e.x.t
and other placeholders.develop
(or merge the Pull Request), then do the same fordevelop
intotrunk
(git checkout develop && git pull origin develop && git checkout trunk && git merge --no-ff develop
).trunk
contains the stable development version.stable
branch to ensure the contents of the diffs are as expected.stable
branch and test it locally to ensure everything works as expected. It is recommended that you rename the existingdistributor
directory and check outstable
fresh because switching branches does not delete files. This can be done withgit clone --single-branch --branch stable git@github.com:10up/distributor.git
stable
branch. Paste the changelog fromCHANGELOG.md
into the body of the release and include a link to the closed issues on the milestone. The release should now appear under releases.stable
branch.Due date (optional)
field) and link to GitHub release (in theDescription
field), then close the milestone.2.0.0
do not make it into the release, update their milestone to2.0.1
,2.1.0
, orFuture Release
.