Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull contents via ajax #1104

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Pull contents via ajax #1104

wants to merge 8 commits into from

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Jun 30, 2023

Description of the Change

Now it pulls contents via ajax to avoid potential request timeout and enhanced user experience.

Closes #121

How to test the Change

  • Go to pull page
  • Pull multiple or single post
  • You should see a modal with minimal progress information

Changelog Entry

Changed - Pull mechanism updated to ajax workflow

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this Jun 30, 2023
assets/js/admin-pull.js Fixed Show fixed Hide fixed
assets/js/admin-pull.js Dismissed Show dismissed Hide dismissed
@jeffpaul jeffpaul added this to the 2.1.0 milestone Jul 10, 2023
@jayedul jayedul removed their assignment Aug 17, 2023
@qasumitbagthariya
Copy link
Contributor

QA Update ✅


I have checked this issue in the update/121 branch and it is working as expected.

Cross-check with Pull multiple or single post ✅

Screenshare.-.2023-11-16.7_34_32.PM.mp4

Status update
cc @jeffpaul

@github-actions github-actions bot added the needs:refresh This requires a refreshed PR to resolve. label Jun 11, 2024
@github-actions github-actions bot removed the needs:refresh This requires a refreshed PR to resolve. label Jun 14, 2024
@jeffpaul
Copy link
Member

@peterwilsoncc back to you for final review/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process pull ui import via ajax
5 participants