-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull contents via ajax #1104
Draft
jayedul
wants to merge
8
commits into
develop
Choose a base branch
from
update/121
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pull contents via ajax #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA Update ✅I have checked this issue in the update/121 branch and it is working as expected. Cross-check with Pull multiple or single post ✅ Screenshare.-.2023-11-16.7_34_32.PM.mp4Status update |
github-actions
bot
added
the
needs:refresh
This requires a refreshed PR to resolve.
label
Jun 11, 2024
github-actions
bot
removed
the
needs:refresh
This requires a refreshed PR to resolve.
label
Jun 14, 2024
@peterwilsoncc back to you for final review/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Now it pulls contents via ajax to avoid potential request timeout and enhanced user experience.
Closes #121
How to test the Change
Changelog Entry
Credits
Props @jayedul
Checklist: