Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail when blob already uploaded #26

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

laanwj
Copy link
Contributor

@laanwj laanwj commented Nov 21, 2024

When the blob was already uploaded by the same pubkey, don't treat this as a fatal error. Return the blob descriptor again, but without increasing reference count.

Closes #12.

i've run cargo fmt and cargo test.

When the blob was already uploaded by the same pubkey, don't treat this
as a fatal error. Return the blob descriptor again, but without
increasing reference count.

Closes 0xtrr#12.
@laanwj
Copy link
Contributor Author

laanwj commented Nov 21, 2024

Huh, can't explain the CI failure, this is what i get locally

running 12 tests
test handlers::tests::has_blob_handler_test ... ok
test handlers::tests::upload_blob_handler_test ... ok
test utilities::validation::tests::test_validate_auth_event_expired ... ok
test utilities::validation::tests::test_validate_auth_event_incorrect_action ... ok
test utilities::validation::tests::test_validate_auth_event_invalid_created_at ... ok
test utilities::validation::tests::test_validate_auth_event_invalid_kind ... ok
test utilities::validation::tests::test_validate_auth_event_missing_action_tag ... ok
test utilities::validation::tests::test_validate_auth_event_missing_expiration_tag ... ok
test utilities::validation::tests::test_validate_auth_event_valid ... ok
test handlers::tests::get_blob_handler_test ... ok
test handlers::tests::delete_blob_handler_test ... ok
test handlers::tests::list_blobs_handler_test ... ok

test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s

@0xtrr
Copy link
Owner

0xtrr commented Nov 21, 2024

I have no idea why the tests failed either, worked fine on my machine and now it works fine when I re-run the action. If this continues to happen, I'll debug it further.

@0xtrr 0xtrr merged commit b1f7e77 into 0xtrr:main Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading a file multple times results in 409 CONFLICT
2 participants