Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: login 페이지 마크업, yarn.lock 버그해결 #63

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

yeynii
Copy link
Contributor

@yeynii yeynii commented Nov 4, 2023

🐶 개요

login 페이지 마크업을 작성했어요.
패키지를 추가할 때마다 yarn.lock에 문제가 생기던 버그를 해결했어요

🐱 설명

🏞️ 스크린샷

image

🤔 참고사항

  • 로그인 버튼이 figma에 사진으로 들어가있어서.... 크기, 위치같은건 그냥 적당히 비슷하게 배치했어요...^^
    image

@yeynii yeynii requested a review from a team as a code owner November 4, 2023 18:02
@yeynii yeynii requested review from xilucks and bullmouse and removed request for a team November 4, 2023 18:02
Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for life-4-cut ready!

Name Link
🔨 Latest commit 5edf3e7
🔍 Latest deploy log https://app.netlify.com/sites/life-4-cut/deploys/6555706d7f3e17000885f090
😎 Deploy Preview https://deploy-preview-63--life-4-cut.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yeynii yeynii self-assigned this Nov 4, 2023
@yeynii yeynii added the Feature 🎡 기능 구현 label Nov 4, 2023
Copy link

github-actions bot commented Nov 4, 2023

@yeynii yeynii changed the title Feature/login feature: login 페이지 마크업, yarn.lock 버그해결 Nov 4, 2023
@yeynii yeynii closed this Nov 12, 2023
@yeynii yeynii deleted the feature/login branch November 12, 2023 09:53
@yeynii yeynii restored the feature/login branch November 12, 2023 09:57
@yeynii yeynii reopened this Nov 12, 2023
xilucks
xilucks previously approved these changes Nov 13, 2023
Copy link
Contributor

@xilucks xilucks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 확인했습니다. 고생하셨어요.

dohun31
dohun31 previously approved these changes Nov 15, 2023
Copy link
Member

@dohun31 dohun31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@yeynii yeynii dismissed stale reviews from dohun31 and xilucks via 5edf3e7 November 16, 2023 01:29
@yeynii yeynii merged commit 53c026f into develop Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants