-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: login 페이지 마크업, yarn.lock 버그해결 #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeynii
requested review from
xilucks and
bullmouse
and removed request for
a team
November 4, 2023 18:02
✅ Deploy Preview for life-4-cut ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Closed
bullmouse
reviewed
Nov 13, 2023
xilucks
previously approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 확인했습니다. 고생하셨어요.
dohun31
previously approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm~
dohun31
approved these changes
Nov 16, 2023
bullmouse
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐶 개요
login 페이지 마크업을 작성했어요.
패키지를 추가할 때마다 yarn.lock에 문제가 생기던 버그를 해결했어요
🐱 설명
jackspeak
2.1.2 이상의 버전이 yarn1 과 충돌하면서 발생하는 버그였어요. package.json 에서jackspeak@2.1.1
로 고정시키는 방법으로 해결했습니당 (참고 - [Bug]: string-width dependency stops storybook from executing storybookjs/storybook#22431 (comment))🏞️ 스크린샷
🤔 참고사항