Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: storybook viewport 추가하기 #62

Merged
merged 1 commit into from
Nov 13, 2023
Merged

feat: storybook viewport 추가하기 #62

merged 1 commit into from
Nov 13, 2023

Conversation

bullmouse
Copy link
Contributor

🐶 개요

  • storybook에 viewport 기능을 추가하기 위해 addon 넣기

🐱 설명

  • 툴바 (화면 상단)의 가장 오른쪽 아이콘을 누르면 됩니다.

🏞️ 스크린샷

스크린샷 2023-10-21 오후 5 04 59

🤔 참고사항

  • (이 PR이 Merge 되지 않았을 때) 자신이 만든 페이지에 적용하고 싶으면 cherry-pick을 하시면 됩니다

@bullmouse bullmouse requested a review from a team as a code owner October 21, 2023 08:08
@bullmouse bullmouse requested review from yeynii and xilucks and removed request for a team October 21, 2023 08:08
@netlify
Copy link

netlify bot commented Oct 21, 2023 •
edited
Loading

✅ Deploy Preview for life-4-cut ready!

Name Link
🔨 Latest commit 1a02a73
🔍 Latest deploy log https://app.netlify.com/sites/life-4-cut/deploys/653386f94dedaa0008fe6a5b
😎 Deploy Preview https://deploy-preview-62--life-4-cut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

🚀 Deployed preview of 1a02a73

name url
Chromatic Build https://www.chromatic.com/build?appId=64e9af23c0cff87d11faa225&number=92
Chromatic Storybook https://64e9af23c0cff87d11faa225-gshcydnbdm.chromatic.com/

xilucks
xilucks approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@xilucks xilucks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 확인했습니다! 고생하셨어요 :)

yeynii
yeynii approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@yeynii yeynii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bullmouse bullmouse merged commit 4e1e520 into develop Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xilucks xilucks xilucks approved these changes

@yeynii yeynii yeynii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bullmouse @yeynii @xilucks