Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/photo-style-checkbox #41

Merged
merged 12 commits into from
Oct 18, 2023
Merged

Conversation

bullmouse
Copy link
Contributor

@bullmouse bullmouse commented Oct 7, 2023

๐Ÿถ ๊ฐœ์š”

  • Checkbox ์ปดํฌ๋„ŒํŠธ๋ฅผ ๋งŒ๋“ค์—ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿฑ ์„ค๋ช…

  • '๋šฑ๋šฑ ๊ฐ€๋กœ/๋šฑ๋šฑ ์„ธ๋กœ/๊ธธ์ญ‰ ์„ธ๋กœ' ์ด๋ ‡๊ฒŒ ์ด 3๊ฐ€์ง€ ๋ฐฉ์‹์ด ์žˆ๊ณ , ์„ ํƒ ์—ฌ๋ถ€์— ๋”ฐ๋ผ ์Šคํƒ€์ผ๋ง์ด ๋‹ฌ๋ผ์ง‘๋‹ˆ๋‹ค.

๐Ÿž๏ธ ์Šคํฌ๋ฆฐ์ƒท

ezgif com-optimize

๐Ÿค” ์ฐธ๊ณ ์‚ฌํ•ญ

์งˆ๋ฌธ๋“œ๋ฆฌ๊ณ  ์‹ถ์€ ์ ์ด 2๊ฐ€์ง€ ์žˆ์Šต๋‹ˆ๋‹ค!

  • flexbox ๋‚ด๋ถ€์— absolute positioning์„ ๋‘์—ˆ๋Š”๋ฐ, ์ด๊ฒŒ ๊ทธ๋ ‡๊ฒŒ ์ข‹์€ ์Šคํƒ€์ผ๋ง ๋ฐฉ์‹์ด๋ผ๊ณ  ๋Š๊ปด์ง€์ง€๋Š” ์•Š์•˜์Šต๋‹ˆ๋‹ค. ๊ทธ๋ ‡๋‹ค๊ณ  ๋‹ค๋ฅธ ๋ฐฉ์‹์œผ๋กœ ํ•˜์ž๋‹ˆ, ์ด๊ฒƒ๋งŒํ•œ ๊ฒŒ ์—†๋‹ค๋Š” ์ƒ๊ฐ์ด ๋“ค์—ˆ์–ด์š”. ์ด์— ๋Œ€ํ•ด ์—ฌ๋Ÿฌ๋ถ„๋“ค์˜ ์˜๊ฒฌ์ด ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค.

  • ์ƒํƒœ ๊ด€๋ฆฌ๋Š” ๋ถ€๋ชจ์—์„œ ํ•œ๋ฒˆ์— ๊ด€๋ฆฌํ•˜๋Š” ๋ฐฉ์‹์œผ๋กœ ์ƒ๊ฐํ–ˆ์–ด์š”. 3๊ฐœ ํƒ€์ž… ์ค‘ 2๊ฐœ๊ฐ€ ์žฌ๋ Œ๋”๋ง ๋˜์–ด์•ผ ํ•˜๊ธฐ ๋•Œ๋ฌธ์ธ๋ฐ, ์—ฌ๋Ÿฌ๋ถ„๋“ค์€ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”?

@bullmouse bullmouse requested a review from a team as a code owner October 7, 2023 02:41
@bullmouse bullmouse requested review from yeynii and dohun31 and removed request for a team October 7, 2023 02:41
@netlify
Copy link

netlify bot commented Oct 7, 2023

โœ… Deploy Preview for life-4-cut ready!

Name Link
๐Ÿ”จ Latest commit e0089d5
๐Ÿ” Latest deploy log https://app.netlify.com/sites/life-4-cut/deploys/652d13b9f979df0008928358
๐Ÿ˜Ž Deploy Preview https://deploy-preview-41--life-4-cut.netlify.app
๐Ÿ“ฑ Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

๐Ÿš€ Deployed preview of e0089d5

name url
Chromatic Build https://www.chromatic.com/build?appId=64e9af23c0cff87d11faa225&number=83
Chromatic Storybook https://64e9af23c0cff87d11faa225-uyoujysodg.chromatic.com/

@dohun31
Copy link
Member

dohun31 commented Oct 7, 2023

  • flexbox ๋‚ด๋ถ€์— absolute positioning์„ ๋‘์—ˆ๋Š”๋ฐ, ์ด๊ฒŒ ๊ทธ๋ ‡๊ฒŒ ์ข‹์€ ์Šคํƒ€์ผ๋ง ๋ฐฉ์‹์ด๋ผ๊ณ  ๋Š๊ปด์ง€์ง€๋Š” ์•Š์•˜์Šต๋‹ˆ๋‹ค. ๊ทธ๋ ‡๋‹ค๊ณ  ๋‹ค๋ฅธ ๋ฐฉ์‹์œผ๋กœ ํ•˜์ž๋‹ˆ, ์ด๊ฒƒ๋งŒํ•œ ๊ฒŒ ์—†๋‹ค๋Š” ์ƒ๊ฐ์ด ๋“ค์—ˆ์–ด์š”. ์ด์— ๋Œ€ํ•ด ์—ฌ๋Ÿฌ๋ถ„๋“ค์˜ ์˜๊ฒฌ์ด ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค.

๋””์ž์ธ ํ•  ๋• space-between์„ ์ƒ๊ฐํ•˜๊ณ  ํ–ˆ์–ด์š”.
๋‹ค๋ฅธ ๋ฐฉ์‹๋ณด๋‹ค absolute๊ฐ€ ๋‚ซ๋‹ค๊ณ  ํ•˜์…จ๋Š”๋ฐ ๋‹ค๋ฅธ ๋ฐฉ์‹๋“ค์€ ์–ด๋–ค๊ฒŒ ์žˆ์—ˆ๋‚˜์š”??

@yeynii
Copy link
Contributor

yeynii commented Oct 7, 2023

react-hook-form์˜ ์ธํ’‹์œผ๋กœ ๋™์ž‘ํ•˜๊ฒŒ ํ•ด์ฃผ์‹ค ์ˆ˜ ์žˆ๋‚˜์šฉ?

@bullmouse
Copy link
Contributor Author

react-hook-form์œผ๋กœ ๋ณ€๊ฒฝํ•˜๊ณ , ์Šคํƒ€์ผ๋„ relative/absolute ๊ฑท์–ด๋‚ด๊ณ  flex-1๋กœ ๋ฐ”๊พธ์—ˆ์Šต๋‹ˆ๋‹ค

Copy link
Contributor

@yeynii yeynii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fat-horizontal.svg <-> fat-vertical.svg ํŒŒ์ผ๋ช…์ด ๋ฐ˜๋Œ€๋กœ ๋œ ๊ฒƒ ๊ฐ™์•„์š”

@bullmouse
Copy link
Contributor Author

fat-horizontal.svg <-> fat-vertical.svg ํŒŒ์ผ๋ช…์ด ๋ฐ˜๋Œ€๋กœ ๋œ ๊ฒƒ ๊ฐ™์•„์š”

ํ— ์ง„์งœ๋„ค์š”..

@bullmouse
Copy link
Contributor Author

์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค~

@bullmouse bullmouse requested a review from yeynii October 16, 2023 10:43
Copy link
Contributor

@yeynii yeynii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ์ˆ˜๊ณ ํ•˜์…จ์–ด์š”~

@xilucks xilucks self-requested a review October 18, 2023 02:14
Copy link
Contributor

@xilucks xilucks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ์ž˜ ๋ณด๊ตฌ๊ฐ‘๋‹ˆ๋‹ค

@bullmouse bullmouse merged commit ae4e8bc into develop Oct 18, 2023
4 checks passed
@yeynii yeynii deleted the feature/photo-style-checkbox branch November 12, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants