Whitespace inside quoted values should not be trimmed

[zaneduffield]

I noticed that quoting a value isn't enough to preserve leading or trailing whitespace.

This code unconditionally trims the value returned by the parse_value function

rust-ini/src/lib.rs

Line 1357 in b2a09b9

mval.trim_in_place();

One of the reasons quoting is commonly supported in ini files is to allow explicit whitespace.

• https://en.wikipedia.org/wiki/INI_file#Quoted_values

I imagine the solution is to move the trim to inside of the parse_value and only call it when the value is unquoted.

[zonyitoo]

The white spaces are preserved between quotes (" and ').

rust-ini/src/lib.rs

Lines 1548 to 1569 in b2a09b9

	let mut val = match self.ch {
	None => Ok(String::new()),
	Some('"') if self.opt.enabled_quote => {
	self.bump();
	self.parse_str_until(&[Some('"')], false).and_then(|s| {
	self.bump(); // Eats the last "
	// Parse until EOL
	self.parse_str_until_eol(cfg!(feature = "inline-comment"))
	.map(|x| s + &x)
	})
	}
	Some('\'') if self.opt.enabled_quote => {
	self.bump();
	self.parse_str_until(&[Some('\'')], false).and_then(|s| {
	self.bump(); // Eats the last '
	// Parse until EOL
	self.parse_str_until_eol(cfg!(feature = "inline-comment"))
	.map(|x| s + &x)
	})
	}
	_ => self.parse_str_until_eol(cfg!(feature = "inline-comment")),
	}?;

[zaneduffield]

Outside of that function, the value is trimmed

rust-ini/src/lib.rs

Line 1357 in b2a09b9

mval.trim_in_place();

When I notice this issue I was only using escaped whitespace (\r\n, for example). That may be relevant.

[zonyitoo]

Ah, right. I couldn't remember why we should trim the value after it was parsed.

[zaneduffield]

But you think that there might be a good reason to do so?