Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class based recorders #111

Open
SamTov opened this issue Mar 5, 2024 · 1 comment
Open

Class based recorders #111

SamTov opened this issue Mar 5, 2024 · 1 comment

Comments

@SamTov
Copy link
Member

SamTov commented Mar 5, 2024

While writing some recorders copilot suggested the following API for adding a class-based recorder:

for i in range(10):
    train_recorder.add_class_recorder(i)

Seems pretty good in the end... You can do the partitioning of the train ds inside of the current recorder and either add a group or spawn a new recorder using data only from that class.

@KonstiNik
Copy link
Member

KonstiNik commented Mar 5, 2024

I already did a draft at some point for that using vmap, which essentially is the same. It is nearly done.
1cf02d9
Is that similar to your idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants