Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species handling struggles with _ #490

Open
PythonFZ opened this issue Jan 31, 2022 · 3 comments
Open

Species handling struggles with _ #490

PythonFZ opened this issue Jan 31, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@PythonFZ
Copy link
Member

PythonFZ commented Jan 31, 2022

Describe the bug
This is just one example

species_split = species.split("_")

that failes if the species contain _ e.g. Na_1

also a bit related to #486

@PythonFZ PythonFZ added the bug Something isn't working label Jan 31, 2022
@SamTov
Copy link
Member

SamTov commented Jan 31, 2022

That can certainly happen in some simulations. There is a possible approach to this I would like to discuss at the general meeting.

@PythonFZ
Copy link
Member Author

That can certainly happen in some simulations. There is a possible approach to this I would like to discuss at the general meeting.

If you have a good idea can you briefly describe it here?

@christophlohrmann
Copy link
Collaborator

christophlohrmann commented Feb 2, 2022

is there a way to keep it internally as tuple(str) and just convert it to the underscore-string when returning it to the user?

tuple means it is fixed order and can be used as a dict key if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants