Checks for separated vector registers #275
Merged
+167
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update this patch |
zherczeg
requested changes
Nov 19, 2024
sljit_src/sljitNativeRISCV_common.c
Outdated
| @@ -3393,7 +3393,6 @@ SLJIT_API_FUNC_ATTRIBUTE sljit_s32 sljit_emit_simd_mov(struct sljit_compiler *co | |||
| sljit_s32 reg_size = SLJIT_SIMD_GET_REG_SIZE(type); | |||
| sljit_s32 elem_size = SLJIT_SIMD_GET_ELEM_SIZE(type); | |||
| sljit_ins ins; | |||
|
|
|||
zherczeg
requested changes
Nov 19, 2024
sljit_src/sljitLir.c
Outdated
| @@ -1001,6 +1035,7 @@ static sljit_s32 function_fcheck(struct sljit_compiler *compiler, sljit_s32 p, s | |||
| #define FUNCTION_CHECK_IS_FREG(fr, is_32) \ | |||
| function_check_is_freg(compiler, (fr)) | |||
|
|
|||
|
|
|||
zherczeg
reviewed
Nov 19, 2024
sljit_src/sljitLir.c
Outdated
| || (vr > (SLJIT_VS0 - compiler->vsaveds) && vr <= SLJIT_VS0) | ||
| || (vr >= SLJIT_TMP_VREGISTER_BASE && vr < (SLJIT_TMP_VREGISTER_BASE + SLJIT_NUMBER_OF_TEMPORARY_VECTOR_REGISTERS)); | ||
| } | ||
| #else |
There was a problem hiding this comment.
Add comments to the #else #endif blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.