Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3.8 Windows DLL loading #926

Closed
pepone opened this issue Jun 24, 2020 · 1 comment
Closed

Python3.8 Windows DLL loading #926

pepone opened this issue Jun 24, 2020 · 1 comment
Milestone

Comments

@pepone
Copy link
Member

pepone commented Jun 24, 2020

Python 3.8 changes the way that extension DLLs are resolved, this affects the 3.8 source build, our pip builds still works

Toblerity/Fiona#851
https://bugs.python.org/issue36085

As this only affects the source builds, I think the simpler will be fto copy the dependencies next to the IcePy.d extension

@pepone pepone added this to the 3.7.5 milestone Jun 24, 2020
@pepone
Copy link
Member Author

pepone commented Jun 25, 2020

A second option will be to call os.add_dll_directory before the call to import IcePy in

import IcePy

The second option will require to add some logic to detect if we are running from a source distribution and locate the C++ bin directory.

Copying the dependencies seems simpler to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant