Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ZoneInfo usage #52

Open
benmccann opened this issue Aug 17, 2017 · 0 comments
Open

Remove ZoneInfo usage #52

benmccann opened this issue Aug 17, 2017 · 0 comments

Comments

@benmccann
Copy link
Contributor

benmccann commented Aug 17, 2017

It's used here:

src/main/java/com/zavtech/morpheus/array/ArrayType.java:            typeMap.put(sun.util.calendar.ZoneInfo.class, TIME_ZONE);

It's generally considered a best practice to avoid using anything from the sun.* package. E.g. see https://stackoverflow.com/a/1835670

I'm not quite sure whether it'd be possible to remove somehow. ArrayBuilderTests.testWithTimeZones tests this functionality and requires the line to be present, but perhaps we could implement some other way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant