Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change operator precedence to C++ standard, string literals escaping too #70

Open
6 tasks
ped7g opened this issue Aug 11, 2019 · 0 comments
Open
6 tasks
Labels
enhancement help wanted input from new users needed, or simple-enough tasks for new contributors
Milestone

Comments

@ped7g
Copy link
Collaborator

ped7g commented Aug 11, 2019

  • add more tests to cover current system even for more complex expression (bugfix v1.x if there's still some bug)
  • write tests for C++ precedence expression evaluator
  • implement the new precedence, probably just patch the current code
  • consider full refactoring to avoid the recursive approach, but research first what can be gain by avoiding the recursive evaluator, feels like the performance is suffering from it, but without benchmarking and research this is bogus claim.

  • string literals: reconsider to have the same escaping as C++, that means also in single apostrophes, maybe even support for full C++ escaping rules (maybe even those unfortunate octals? But only in strings?)
  • reconsider having octals as C++ ... (I mean no, just no, it's horrible) (but let's consider it one more time for v2.x)

help wanted: to add tests for more tricky expressions and exercising current precedence, to verify v1.x correctness

@ped7g ped7g added this to the v2.x milestone Aug 11, 2019
@ped7g ped7g changed the title Change operator precedence to C++ standard. Change operator precedence to C++ standard, string literals escaping too Aug 11, 2019
@ped7g ped7g added the help wanted input from new users needed, or simple-enough tasks for new contributors label Aug 25, 2019
@ped7g ped7g pinned this issue May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted input from new users needed, or simple-enough tasks for new contributors
Projects
None yet
Development

No branches or pull requests

1 participant