Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for diff log and less #39

Open
ghost opened this issue Jul 28, 2021 · 4 comments
Open

Request for diff log and less #39

ghost opened this issue Jul 28, 2021 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 28, 2021

As a web designer who's always compiling, I'd really benefit from diff log and less support.

@yoeo
Copy link
Owner

yoeo commented Jul 29, 2021

Diff:
✔️ more than enough files publicly available for training https://github.com/search?q=extension%3Adiff
⚠️ Diff support could clash with basically all the other languages. As Diff code is other languages code with special markups

LESS:
✔️ more than enough files publicly available for training https://github.com/search?q=extension%3Aless
⚠️ Could clash with CSS. Other languages should be fine.

Log:
I'm not sure about which kind of files/logs you are referring to @4086606

@ghost
Copy link
Author

ghost commented Jul 29, 2021

@yoeo
Copy link
Owner

yoeo commented Jul 29, 2021

Thanks for the example.

Log:
✔️ more than enough files publicly available for training https://github.com/search?p=100&q=extension%3Alog&type=Code
⚠️ different log files can have different structures depending on the log source, and the model that I use works poorly when the training files don't have the same underlying structure.

To sum it up:

  • I will add LESS to the next batch of languages to support
  • I may add Diff, if it doesn't break the detection confidence of other languages
  • and I think that I will skip Log, because the model is not smart enough to handle such a flexible format

@ghost
Copy link
Author

ghost commented Jul 29, 2021

Alright that's fine by me. Thanks for the quick replies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant