less memory usage when writing a dataframe #45
Merged
+15
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slemouzy
force-pushed
the
reduce-write-memory-usage
branch
from
bd68b72
to
13ab063
Compare
@marctorsoc Basically, yes. How do you think about leaving the existing implementation as is? (The idea is to branch the process based on some parameter) |
|
I don't quite understand your comment. The current implementation does here, which means doubling the memory as the OP is trying to fix I did not review the specific implementation in the PR, but I'm sure if he knows you'll approve, he'll be more motivated to fix the conflicts 😃 . Worst case scenario, I'm happy to fix it |
|
@marctorsoc Thank you, I misunderstood. Let's incorporate this change. |
Instead of converting the whole DataFrame into a list of dicts (which can double the memory usage), uses a generator to iterate on the rows of the DataFrame converting each row one after the other.
slemouzy
force-pushed
the
reduce-write-memory-usage
branch
from
13ab063
to
2a1a4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of converting the whole DataFrame into a list of dicts (which can double the memory usage), uses a Generator function to iterate on the rows of the DataFrame converting each row one after the other.