Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Markdown renderer #87

Closed
noraj opened this issue Sep 23, 2016 · 6 comments
Closed

Markdown renderer #87

noraj opened this issue Sep 23, 2016 · 6 comments
Labels
Supports in Marp Next The tagged issue has/would resolved in repos on @marp-team, and might close in near future.

Comments

@noraj
Copy link

noraj commented Sep 23, 2016

Hi Yuki,

I love your project this is pretty amazing and usefull

BUT the markdown renderer/parser you use doesn't respect markdown syntax at all.

There is a lot of examples with list, quotes, line feed etc ...

You can tests examples of syntax from the original markdown:
https://daringfireball.net/projects/markdown/syntax

That would be great if your replace the renderer you actually use with one implementing all markdown features + Github Flavored Markdown ones.

There is a lot of markdown renderer / parser that won't be a problem.

@honzajavorek
Copy link

http://commonmark.org/ ?

@noraj
Copy link
Author

noraj commented Sep 28, 2016

@honzajavorek : what do you suggest ?

@honzajavorek
Copy link

honzajavorek commented Oct 3, 2016

@noraj1337 The problem with the original Markdown "spec" is that it insufficiently describes all corner cases of Markdown parsing. That's why CommonMark was created as a way to standardize around some kind of community-maintained spec.

So,

  1. If marp already uses CommonMark (I didn't check) and your issues are that the CommonMark-spec-compilant parser works in a different way than you would expect from the original Markdown spec, then I'd suggest to stick to CommonMark anyway, as it's currently the only sane way to support Markdown today and in the near future, with expectable results.
  2. If marp doesn't use CommonMark yet, then I suggest to migrate to it and use CommonMark-spec-compilant parser, which should avoid any future issues like this (because 1.).

@noraj
Copy link
Author

noraj commented Oct 3, 2016

@honzajavorek : Yeah you're right, and commonMark is really good initiative but it does support only original markdown. For example array (from GMF) are quite useful and used everywhere but not supported by commonMark.

Here is what GMF add more : https://help.github.com/enterprise/11.10.340/user/articles/github-flavored-markdown/

And here is github parser : https://github.com/github/markup

I don't if it possible to use commonMark + GMF features.

But there is a lot of others additions (https://github.com/jgm/CommonMark/wiki/Markdown-Flavors).

@yhatt yhatt added the Supports in Marp Next The tagged issue has/would resolved in repos on @marp-team, and might close in near future. label Aug 21, 2018
@yhatt
Copy link
Owner

yhatt commented Jun 4, 2019

It has already resolved in Marp Next. It has grown durable against a practical use, so we close this issue.

Details

yhatt/marp had already used markdown-it, the 100% CommonMark compliant parser. But I had not used CommonMark option in constructor option. So we had decided to strictly respect CommonMark (0.28) by default in Marpit, the brand-new framework of Marp Next ecosystem (#267).

Additional syntax never breaks CommonMark document. And we will hate extra syntax to require breaking CommonMark. (But power user can extend favorite syntax by markdown-it plugin.)

Our new core based on Marpit has carefully selected extra syntaxes: GFM table, Pandoc style math typesetting, and emoji shorthand.

@yhatt yhatt closed this as completed Jun 4, 2019
@noraj
Copy link
Author

noraj commented Jun 4, 2019

@yhatt Yeah respecting CommonMark is a good idea. I didn't use Marp Next but I read the new idea of the project and it just looks amazing. I'm didn't write slides since a lot of times but I'll sure use Marp when I'll do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Supports in Marp Next The tagged issue has/would resolved in repos on @marp-team, and might close in near future.
Projects
None yet
Development

No branches or pull requests

3 participants