Fix joining with samba 4.21

[scabrero]

Problem

Samba 4.21 changes the way the system keytab is created. To add the machine account name to the keytab it is necessary to set sync machine password to keytab = /etc/krb5.keytab:account_name:sync_etypes:sync_kvno:machine_password in /etc/smb.conf.

Solution

Detect the installed samba version and add the necessary parameter.

Testing

Manually tested.

[coveralls]

Pull Request Test Coverage Report for Build 11363037220

Details

• 15 of 32 (46.88%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.4%) to 25.198%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/lib/auth/authconf.rb	14	31	45.16%

Totals
Change from base Build 10845491006:	0.4%
Covered Lines:	478
Relevant Lines:	1897

---

💛 - Coveralls

[joseivanlopez]

Sorry for being late with the review. We have been busy with other stuff.

The code looks correct, although I have suggested some improvements. Basically, we should stop using the old Yast::Builtins and similar methods. As long as possible, please let's use ruby std classes and methods instead.

I see there already is a test/authconf_test.rb file. Could be possible to add some tests for these changes there?

Thanks!

[scabrero]

Sorry for being late with the review. We have been busy with other stuff.

The code looks correct, although I have suggested some improvements. Basically, we should stop using the old Yast::Builtins and similar methods. As long as possible, please let's use ruby std classes and methods instead.

I see there already is a test/authconf_test.rb file. Could be possible to add some tests for these changes there?

Thanks!

Thanks for the review, this looks much better now. I have added a test for the version check.

[joseivanlopez]

Version bump is missing in package/yast2-auth-client.spec.

[joseivanlopez]

I see you marked as solved my last 2 comments, but I see no changes in the code. And the spec file is not updated neither with the new version.

[scabrero]

I see you marked as solved my last 2 comments, but I see no changes in the code. And the spec file is not updated neither with the new version.

Sorry, I wanted to test the changes before pushing and some tasks got in the middle.

[joseivanlopez]

LGTM

[dgdavid]

Sorry @scabrero, I was on vacation when the review was requested. Fortunately, @joseivanlopez took care and changes looks good to him. So, I guess you can hit the merge button 🎉

[github-actions]

❌ Autosubmission job #11437603416 failed

[dgdavid]

Auto-submission sent successfully after adding a reference in the latest changelog entry, see #123 (comment)