-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to complete upload #154
Comments
Here's a data point that might be useful - I was able to successfully upload on my Mac (M1 mini) running Big Sur (MacOS version 11.6.2). Java installed using "brew install java" using these directions: That is, after brew install, I made the java command usable by linking it like this: $ java -version Running it like this: Running v22.02 pattypan, all worked out fine. Using two factor authentication, I used a bot password. Here's the file: |
update: using openjdk version 17.0.2 seems to work without errors! |
@Ambrosiani @fuzheado do you too need to load the module with |
@Abbe98 I need to add the module. When I run the plain
|
What error do you get if you run |
M1 (arm) Mac Mini, Monterey 12.1. Same as fuzheado :) verbose error:
|
I built and tested Pattypan for x64 thinking that Mac remained backward compatible across the many changes of architecture, but maybe the M1 broke that. That said the original issue appears to be something different, but this is worth keeping in mind as we might need separate builds for MacOS. |
(base) ian@MacBook-Pro-2 Desktop % java -Djavafx.verbose=true -Dprism.verbose=true jar pattypan.jar My mac is pre-M1: Java version: And I have javafx-sdk-17.0.2 for X64. Let me know if I can help more. |
@watty62 there's a missing hyphen in that command, try |
Thanks @Ambrosiani It runs Pattypan and gives the following output (base) ian@MacBook-Pro-2 Desktop % java -Djavafx.verbose=true -Dprism.verbose=true -jar pattypan.jar Feb 08, 2022 9:46:18 AM com.sun.javafx.application.PlatformImpl startup WARNING: Unsupported JavaFX configuration: classes were loaded from 'unnamed module @4d937939' Prism pipeline init order: es2 sw Using Double Precision Marlin Rasterizer Using dirty region optimizations Not using texture mask for primitives Not forcing power of 2 sizes for textures Using hardware CLAMP_TO_ZERO mode Opting in for HiDPI pixel scaling Prism pipeline name = com.sun.prism.es2.ES2Pipeline Loading ES2 native library ... prism_es2 WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /Users/ian/Desktop/libprism_es2.dylib Loaded library /libprism_es2.dylib from resource succeeded. GLFactory using com.sun.prism.es2.MacGLFactory (X) Got class = class com.sun.prism.es2.ES2Pipeline Initialized prism pipeline: com.sun.prism.es2.ES2Pipeline JavaFX: using com.sun.javafx.tk.quantum.QuantumToolkit WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /Users/ian/Desktop/libglass.dylib Loaded library /libglass.dylib from resource Maximum supported texture size: 16384 Maximum texture size clamped to 4096 Non power of two texture support = true Maximum number of vertex attributes = 16 Maximum number of uniform vertex components = 4096 Maximum number of uniform fragment components = 4096 Maximum number of varying components = 128 Maximum number of texture units usable in a vertex shader = 16 Maximum number of texture units usable in a fragment shader = 16 Graphics Vendor: ATI Technologies Inc. Renderer: AMD Radeon Pro 560X OpenGL Engine Version: 2.1 ATI-4.7.101 vsync: true vpipe: true WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /Users/ian/Desktop/libjavafx_font.dylib Loaded library /libjavafx_font.dylib from resource Feb 08, 2022 9:46:20 AM pattypan.Main main INFO: Wiki set as: commons.wikimedia.org Protocol set as: https:// Script path set as: /w Feb 08, 2022 9:46:20 AM pattypan.Main main INFO: Operating System: Mac OS X Pattypan Version: 22.02 ES2ResourceFactory: Prism - createStockShader: FillPgram_Color.frag ES2ResourceFactory: Prism - createStockShader: Solid_TextureFirstPassLCD.frag ES2ResourceFactory: Prism - createStockShader: Solid_TextureSecondPassLCD.frag new alphas with length = 49152 ES2ResourceFactory: Prism - createStockShader: Texture_Color.frag ES2ResourceFactory: Prism - createStockShader: DrawRoundRect_Color.frag ES2ResourceFactory: Prism - createStockShader: Solid_TextureRGB.frag |
Today I installed Virtual Box and configured an Ubuntu 20 VM. I installed Open Java JDK and Open JavaFX 17.0.2 I ran Pattypan and tried to upload two files. I hit exactly the same issue as reported in the original issue above. ie Pattypan runs ok, allows me to generate a spreadsheet. I can validate the spreadsheet ok, and then try to upload. It authenticates and starts to upload the first file but never finishes. Whereas the OS has changed from Mac OSX 12 to Ubuntu 20.04.3, the Java and JavaFX versions are the same. Running the command from @Ambrosiani above I hope that this helps! Ian watty@watty-VirtualBox:~/Documents$ java -Djavafx.verbose=true -Dprism.verbose=true -jar pattypan.jar Feb 08, 2022 7:25:12 PM com.sun.javafx.application.PlatformImpl startup WARNING: Unsupported JavaFX configuration: classes were loaded from 'unnamed module @685f4c2e' Prism pipeline init order: es2 sw Using Double Precision Marlin Rasterizer Using dirty region optimizations Not using texture mask for primitives Not forcing power of 2 sizes for textures Using hardware CLAMP_TO_ZERO mode Opting in for HiDPI pixel scaling Prism pipeline name = com.sun.prism.es2.ES2Pipeline Loading ES2 native library ... prism_es2 WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /home/watty/Documents/libprism_es2.so Loaded library /libprism_es2.so from resource succeeded. GLFactory using com.sun.prism.es2.X11GLFactory (X) Got class = class com.sun.prism.es2.ES2Pipeline Failed Graphics Hardware Qualifier check. System GPU doesn't meet the es2 pipe requirement GraphicsPipeline.createPipeline: error initializing pipeline com.sun.prism.es2.ES2Pipeline *** Fallback to Prism SW pipeline Prism pipeline name = com.sun.prism.sw.SWPipeline WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /home/watty/Documents/libprism_sw.so Loaded library /libprism_sw.so from resource (X) Got class = class com.sun.prism.sw.SWPipeline Initialized prism pipeline: com.sun.prism.sw.SWPipeline JavaFX: using com.sun.javafx.tk.quantum.QuantumToolkit WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /home/watty/Documents/libglass.so Loaded library /libglass.so from resource WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /home/watty/Documents/libglassgtk3.so Loaded library /libglassgtk3.so from resource vsync: true vpipe: false WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /home/watty/Documents/libjavafx_font.so Loaded library /libjavafx_font.so from resource Feb 08, 2022 7:25:13 PM pattypan.Main main INFO: Wiki set as: commons.wikimedia.org Protocol set as: https:// Script path set as: /w Feb 08, 2022 7:25:13 PM pattypan.Main main INFO: Operating System: Linux Pattypan Version: 22.02 WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /home/watty/Documents/libjavafx_font_freetype.so Loaded library /libjavafx_font_freetype.so from resource WARNING: java.lang.UnsatisfiedLinkError: Can't load library: /home/watty/Documents/libjavafx_font_pango.so Loaded library /libjavafx_font_pango.so from resource |
@watty62 it indeed looks like the upload of the first image never finishes. Would you be able to share the first file? Some files just don't play nice with Pattypan nor Commons, especially TIFF files but it happens to other formats as well. |
@Abbe98 I didn't think of that as a common issue - ie using the same file each time. Here it is: https://www.dropbox.com/s/1f6eln8cfxf9cki/20220126_125956.jpg?dl=0 Thanks Ian |
Yes, to be clear, when it worked "out of the box" with OpenJDK 15.0.2 and found JavaFX automatically I think it was using an old installation from Oracle, so it was bundled in. When I used "brew install java" with is openjdk 17.0.2, I need to manually download JavaFX and include the module path and module. |
@Abbe98 using a different photo I was able to upload via Pattypan on the Mac. Two of my own images failed but this PD / CC0 one worked. It is of much smaller dimensions, whereas my own were 4,032 x 1,816 px and 3MB+ I am going to try another batch later today or tomorrow. I will note the outcomes here. |
I have the same issue: Pattypan 22.02 starts fine and gets stuck at the upload of the first image. This happened in Windows 10, Ubuntu 21.10 and Ubuntu 18.04. I had the same issue with the experimental releases 3 and 4, as documented here: #145, though @MER-C was able to upload my images to test.wikipedia.org without problems. I tried with OpenJDK 11 and 17. Additional info: On Windows 10, when I start 22.02 with java -jar pattypan.jar, I get the following warning: |
Here's my output for $JAVA_HOME/bin/java -Djavafx.verbose=true -Dprism.verbose=true --module-path $PATH_TO_FX --add-modules javafx.web -jar Downloads/pattypan_22.jar: Loaded C:\Java\javafx-sdk-17.0.1\lib..\bin\api-ms-win-core-console-l1-1-0.dll from relative path |
@annalauraw it appears that this issue is caused by the files in question. Could you too share the ones which fail? One solution that could be tried is to convert the problematic images to another format and back agian. |
Here you can find the failing files: https://drive.switch.ch/index.php/s/nXiYUN34qGfhQsZ. It's the same files that @MER-C was able to upload to test.wikipedia.org without problems, as mentionied in #145 (comment). In our workflow, we download the images from our digital library platform in .jpg format using a Python script (download image as stream via IIIF API and save to .jpg file). Could the problem lie in this process? |
I tried to convert the .jpg files to png format and back, but the upload still doesn't work. Could spaces or other special characters in the file name (not in image path on local disk) be a problem? For instance CH-ZBZ-[Ausbeüte der Böcken, bey Belagerung der Statt Zürich]-991012222739705501.jpg |
Turns out the brackets in the file name were causing the problem! Without the brackets, it worked. May be useful to know for other GLAM users since librarians tend to put titles which are found outside of the image resource in square brackets. |
@annalauraw great, the March release will contain #133 that should introduce a warning for such issues. |
I can confirm that a file name with an accidental carriage return in it also fails to upload (whereas those containing double quotes or forward slashes are fixed in the upload process) |
I am having what seems to be the same issue with 22.03 - I'm able to generate a spreadsheet but when I go to upload it will upload a few files (as few as one and up to maybe 15) and then stops. I've been stopping the upload when it seems stalled out, reordering the files in the upload spreadsheet and trying again. It will do the same thing - upload a few files and then stop. It doesn't seem to be tied to one particular file because after reordering, the file that it stopped on the previous time will be uploaded without issue. I'm operating in Windows 10. |
@bettinacsmith could you provide additional information about the files you are uploading? Wikimedia Commons uploads commonly and irregularly fail for a series of issues on the Wikimedia side(large files, TIFF files, etc are all common things that contribute). |
They are all JPEG files. Here is the portion of the batch that I was able to upload: https://commons.wikimedia.org/wiki/Category:Atil,_Syria |
I've been testing 20.04 and now 22.02 on Mac OSX (Monterey 12.1).
In each case, Pattypan runs ok, allows me to generate a spreadsheet. I can validate the spreadsheet ok, and then try to upload. It authenticates and starts to upload but never finishes, even if I leave one file to upload for 2 hours.
This is the output. I hope that it is helpful.
It goes no further than that.
The text was updated successfully, but these errors were encountered: