From 7317a6295b3e2045d8786026c2cadae359a52aaa Mon Sep 17 00:00:00 2001 From: Antoine Mottier Date: Tue, 20 Feb 2024 14:39:49 +0100 Subject: [PATCH] XWIKI-21894: JSC_PARSE_ERROR in Tour.WebHome (#2895) Use double quotes for icon aria-hidden value The single quotes leads to error for example with tour extension: ``` xwiki:Tour.WebHome:17:78: ERROR - [JSC_PARSE_ERROR] Parse error. ',' expected 17| $(' Launch') ^ 1 error(s), 0 warning(s) ``` (cherry picked from commit 3fe9ffeab1715358f07b94709da48d91c494b8c1) --- .../src/main/resources/IconThemes/FontAwesome.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-fontawesome/src/main/resources/IconThemes/FontAwesome.xml b/xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-fontawesome/src/main/resources/IconThemes/FontAwesome.xml index f12f51c8a704..e275d6dacaac 100644 --- a/xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-fontawesome/src/main/resources/IconThemes/FontAwesome.xml +++ b/xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-fontawesome/src/main/resources/IconThemes/FontAwesome.xml @@ -39,8 +39,8 @@ ## General settings xwiki.iconset.type = font xwiki.iconset.css = $services.webjars.url('org.webjars:font-awesome', 'css/font-awesome.min.css') -xwiki.iconset.render.wiki = {{html clean="false"}}<span class="fa fa-$icon" aria-hidden='true'></span>{{/html}} -xwiki.iconset.render.html = <span class="fa fa-$icon" aria-hidden='true'></span> +xwiki.iconset.render.wiki = {{html clean="false"}}<span class="fa fa-$icon" aria-hidden="true"></span>{{/html}} +xwiki.iconset.render.html = <span class="fa fa-$icon" aria-hidden="true"></span> xwiki.iconset.icon.cssClass = fa fa-$icon ## XWiki Icon Set (see: http://design.xwiki.org/xwiki/bin/view/Proposal/XWiki+Icon+Set).