Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Remove @testable from tests unless it is explicitly needed #373

Open
cameronvoell opened this issue Jul 24, 2024 · 0 comments
Open

Feature request: Remove @testable from tests unless it is explicitly needed #373

cameronvoell opened this issue Jul 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cameronvoell
Copy link
Contributor

cameronvoell commented Jul 24, 2024 •
edited
Loading

Is your feature request related to a problem?

@testable imports in our tests allows us to access internal only fields and classes that users of the SDK would not be able to access. There are some spots in our tests where we are utilizing internal only properties that incorrectly demonstrate how to use the SDK. Removing @testable import of XMTPiOS from our tests will help us catch this in tests.

Describe the solution to the problem

No response

Describe the uses cases for the feature

No response

Additional details

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cameronvoell