Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] rewrite the dictionary panel logic #1873

Open
xiaoyifang opened this issue Oct 26, 2024 · 4 comments
Open

[Feature] rewrite the dictionary panel logic #1873

xiaoyifang opened this issue Oct 26, 2024 · 4 comments

Comments

@xiaoyifang
Copy link
Owner

xiaoyifang commented Oct 26, 2024

Is your feature request related to a problem? Please describe.

When add new folders , the panels of Dictionaries and Groups are recreated . Which has caused the whole page freeze ,
image

Describe the solution you'd like
I'd like to reuse the existed panels and refresh the data without recreating the panels.


Another solution :

split this dialog into two dialogs. One with Sources ,the other will Dictionaries & Groups

Additional context
I suspected that this may have some connection with rarely crash on Macos. #574

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Oct 29, 2024

Will the new menu confusing?

Based on #1881, the menu will become

Edit
  --> Sources
  --> Dictionaries
        --> Dictionaries
        --> Groups

The Dictionaries now becomes Dictionaries + Groups.

The Sources loses the master dialog of Edit Dictionaries, so will someone question the Sources of what?


Personally, I like 3 dialogs #1606

Dictionaries (Change Edit -> Dictionaries)
  --> Add Sources
  --> Inspect Dictionaries
  --> Manage Groups

(or keep the Edit so that we can add #1695 under Edit)

@xiaoyifang
Copy link
Owner Author

xiaoyifang commented Oct 29, 2024

What about

Edit
  --> Dictionary Sources
  --> Dictionaries & Groups
        --> Dictionaries
        --> Groups

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Oct 29, 2024

I feel Dictionaries and Groups are two distinctive concepts that don't share a root name.

The old one avoids this problem by amalgamating everything together.

In Dictionaries & Groups, the Groups will be one level deeper, and requires one extra click to reach it.


The Dictionaries's extra feature is 1. reordering dictionaries 2. disable some dictionaries.

Maybe we can just combine Dictionaries & Groups 😅

@xiaoyifang
Copy link
Owner Author

xiaoyifang commented Oct 29, 2024

I feel Dictionaries and Groups are two distinctive concepts that don't share a root name.

groups based on dictionaries , they have tight connections.
If one dictionary got disabled in dictionaries panel, this dictionary will not show in groups panel

The old one avoids this problem by amalgamating everything together.

In Dictionaries & Groups, the Groups will be one level deeper, and requires one extra click to reach it.

The Dictionaries's extra feature is 1. reordering dictionaries 2. disable some dictionaries.

Maybe we can just combine Dictionaries & Groups 😅

too much effort ,can be in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants