Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great work, a small typo #9

Open
wehos opened this issue Feb 8, 2024 · 3 comments
Open

Great work, a small typo #9

wehos opened this issue Feb 8, 2024 · 3 comments

Comments

@wehos
Copy link

wehos commented Feb 8, 2024

Thank you for your great work. It seems like there is an indentation error here:

else:

Can you please take a look?

@wehos
Copy link
Author

wehos commented Feb 8, 2024

Besides, there are a missing dependency munkres in README. It was used in utils.py.

fi1 and fi2 arguments, etc in Run SMAGE-seq PBMC10K script do not exist in run_scMDC.py file.

@wehos
Copy link
Author

wehos commented Feb 8, 2024

def fit(self, X1, X_raw1, sf1, X2, X_raw2, sf2, y=None, lr=1., n_clusters = 4,

fit function here does not have t argument, but run_scMDC.py passed it here.

X2=adata2.X, X_raw2=adata2.raw.X, sf2=adata2.obs.size_factors, y=None, t=1,

@xianglin226
Copy link
Owner

Thanks for your comments. We will fix the typos soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants