Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

WP folders are not ignored when dist is not ignored #205

Open
arekf opened this issue Dec 16, 2015 · 1 comment
Open

WP folders are not ignored when dist is not ignored #205

arekf opened this issue Dec 16, 2015 · 1 comment
Milestone

Comments

@arekf
Copy link

arekf commented Dec 16, 2015

When dist folder is not addded to .gitignore, WordPress ignored folders are also not being added, see: https://github.com/xhtmlized/generator-xh/blob/master/app/templates/gitignore#L36

Is there any reason for that?

@arekf arekf changed the title WP folders are not ignored when dist is not ignored. WP folders are not ignored when dist is not ignored Dec 16, 2015
@piotrkulpinski piotrkulpinski added this to the v0.8 milestone Feb 3, 2016
@piotr-bajer
Copy link
Contributor

piotr-bajer commented May 31, 2016

Is this because of syntax error? Instead:

bower_components<% if (ignoreDist) { %>
dist<% if (isWP) { %>
wp/wp-content/themes/**/img
wp/wp-content/themes/**/fonts
wp/wp-content/themes/**/js
wp/wp-content/themes/**/css
wp/wp-content/themes/**/media
wp/wp-content/uploads<% } %><% } %>

should be:

bower_components<% if (ignoreDist) { %>
/dist<% } %><% if (isWP) { %>
wp/wp-content/themes/**/img
wp/wp-content/themes/**/fonts
wp/wp-content/themes/**/js
wp/wp-content/themes/**/css
wp/wp-content/themes/**/media
wp/wp-content/uploads<% } %>

Note "/dist" instead "dist" because of problems this definition introduces to some plugins (i.e. Yoast SEO) which uses such folder name.

See pull request: #219

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants