Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blacklisting of webhook servers #68

Open
eminano opened this issue Sep 2, 2024 · 0 comments
Open

Support blacklisting of webhook servers #68

eminano opened this issue Sep 2, 2024 · 0 comments

Comments

@eminano
Copy link
Collaborator

eminano commented Sep 2, 2024

While it's the subscription server exposes an endpoint to unsubscribe from the webhook notifications, it relies on the receiver to make a request. It can happen that subscribed servers are in a bad state (always returning error status), or down altogether. Currently all the subscriptions are kept regardless, which could be exploited.

One solution could be to force the subscriber to re-subscribe after a set time period, but this can be annoying, since we force the receiver to constantly re-subscribe, leading to missing notifications. Another solution could be to blacklist servers that are not healthy, keeping them for a period of time before deleting them altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant