Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Black screen on all whitelisted ads #48

Open
filippesic opened this issue Apr 19, 2023 · 4 comments
Open

Black screen on all whitelisted ads #48

filippesic opened this issue Apr 19, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@filippesic
Copy link

Hi,

I'm not sure if this is a bug, but it sure wasn't working like this a month ago. Every ad is just a black screen and even tho some ads are interesting I cannot click or visit the site for that ad.

Cheers

Firefox 112.0.1
Windows 10 latest update
Identical issue on Macbook Air M1 with same Firefox version, latest MacOS

Screenshot (8)

Screenshot (7)

@Steve3854
Copy link

I just discovered this extension and am having the same issue. Also can't click through to the advertiser. Would be fine, but my only concern is I'm not sure if youtube channels get anything if the ad is unlickable and without video.

@filippesic
Copy link
Author

I just discovered this extension and am having the same issue. Also can't click through to the advertiser. Would be fine, but my only concern is I'm not sure if youtube channels get anything if the ad is unlickable and without video.

Exactly what I was thinking 🙂

@x0a x0a self-assigned this Apr 25, 2023
@x0a x0a added the bug Something isn't working label Apr 25, 2023
@x0a
Copy link
Owner

x0a commented Apr 25, 2023

Hey,

Thank you for the report. I've reproduced and confirmed the issue. Working on this now and should have an update by the end of the week.

Thanks

@x0a
Copy link
Owner

x0a commented Apr 29, 2023

So turns out the issue is caused by the youtube##.ad-showing > .html5-video-container rule in EasyList, setting the .html5-video-container display property to none when ads are playing. Since this is an injected content script (vs the injected userscripts that this extension uses), it's difficult to override without also using a content script, which I will eventually do.

But in the meantime, this extension re-implements all adblocking by uBO's default lists, so its possible to disable uBO altogether on YouTube, this extension will still block/remove ads as it detects them.

I'll have a new release addressing the issue within the week.

Thanks

x0a added a commit that referenced this issue May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants