Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend WvcLib for library binding #499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lmangani
Copy link

@lmangani lmangani commented Nov 23, 2024

Implements and exports a new function wvlet_compile_query to compile wvlet query and return the SQL as a string. The binding has been tested working with an experimental native DuckDB Extension on linux/x86

D CREATE TABLE t1 AS SELECT 42 AS i, 84 AS j;
D SELECT * FROM wvlet('from t1');
-- wvlet version=0.0.0+1-e9ceb08b+20241123-2203, src=01JDDN09HBS0DEYDCPRZGYNTKC.wv:1
select * from t1
┌───────┬───────┐
│   i   │   j   │
│ int32 │ int32 │
├───────┼───────┤
│    4284 │
└───────┴───────┘

Note the mandatory debug print from WvcMain.scala is still present. It would be nice to add an option to disable it.

I never used Scala before, apologies shall this humble PR be improperly implemented 🤞 ready to learn if that's the case

Potential self-fix for #498

Implements and exports a new function `wvlet_compile_query` to compile wvlet query and return the SQL as a string. Tested working with native DuckDB Extension.

I never used Scala before, apologies shall this PR be improperly implemented 🤞 

Potential fix for wvlet#498
@lmangani lmangani mentioned this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant