Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy server configuration for blocking mode should be consistent with that of non-blocking mode #284

Open
tharikaGitHub opened this issue May 2, 2018 · 1 comment

Comments

@tharikaGitHub
Copy link
Member

Description:
The following proxy configuration parameters set in axis2.xml should work when added to axis2_blocking_client.xml in blocking scenarios. (<call blocking="true">)

<parameter locked="false" name="http.proxyHost">localhost</parameter>
<parameter locked="false" name="http.proxyPort">8080</parameter>
<parameter locked="false" name="http.nonProxyHosts">example.com</parameter>

Setting these parameters under org.apache.axis2.transport.http.CommonsHTTPTransportSender configuration doesn't work. They are being taken in as system parameters. Check [1] for more details.

As a solution, we can include code to read the above parameter values from the axis2_blocking_client.xml to method [2]. Also when validating nonProxyHosts, [3] should be modified to read from the configuration in addition to system properties. And [4] should be modified to reflect this logic of reading above parameters when checking if proxy is enabled.

[1] https://wso2.org/jira/browse/DOCUMENTATION-6914
[2] https://github.com/wso2/wso2-axis2/blob/master/modules/transport/http/src/org/apache/axis2/transport/http/util/HTTPProxyConfigurationUtil.java#L84
[3] https://github.com/wso2/wso2-axis2/blob/master/modules/transport/http/src/org/apache/axis2/transport/http/util/HTTPProxyConfigurationUtil.java#L277
[4] https://github.com/wso2/wso2-axis2/blob/master/modules/transport/http/src/org/apache/axis2/transport/http/util/HTTPProxyConfigurationUtil.java#L241

@npamudika npamudika transferred this issue from wso2/wso2-axis2 Jul 10, 2023
@npamudika
Copy link
Contributor

The issue is transferred from wso2/wso2-axis2 repo as discussed internally and this will be considered in a future release.

@msm1992 msm1992 transferred this issue from wso2/product-apim Jul 13, 2023
@nandika nandika transferred this issue from wso2/api-manager May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants