Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added backToTop module #26

Merged
merged 3 commits into from
Nov 8, 2023
Merged

added backToTop module #26

merged 3 commits into from
Nov 8, 2023

Conversation

gardenboi
Copy link
Collaborator

just made a simpler version of backToTop getting rid of MutationObserver

@erikyo erikyo self-requested a review November 8, 2023 21:35
erikyo
erikyo requested changes Nov 8, 2023
View reviewed changes
src/scripts/modules/backToTop/backToTop.ts Outdated Show resolved Hide resolved
src/scripts/modules/backToTop/backToTop.ts Outdated Show resolved Hide resolved
src/scripts/scripts.ts Outdated Show resolved Hide resolved
@gardenboi gardenboi requested a review from erikyo November 8, 2023 22:03
gardenboi
gardenboi commented Nov 8, 2023
View reviewed changes
Copy link
Collaborator Author

@gardenboi gardenboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do did done

@gardenboi gardenboi merged commit 0c43229 into master Nov 8, 2023
4 checks passed
@erikyo erikyo deleted the backToTopModule branch November 8, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikyo erikyo erikyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gardenboi @erikyo