-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from token-based to OIDC-ish login #249
Comments
no authproxy. we do not need an extra service |
Agreed... I would've loved writing security-critical code in RISC assembly, though! (just kidding) |
/cc @Trentiumz @mars-flat as client and app leads |
I don't trust your "secure" code.... you've printed passwords & allowed anyone to bypass all authentication on api 😨 |
That's true! I'm sure I've learned lessons from them, and 90% sure I won't make those mistakes again (by staying away from security code...)! |
to anyone reading this in the future... ken is a very trustworthy and cool person!!! HIRE THEM (and me too pls I'm probably struggling and jobless.....wow look at my cool contribution history) |
Currently, the app and React-based client uses the
/api/auth/token
endpoint with a username+password pair to login the user./api/auth/token
relies on JWTs (pros/cons listed below), andPros to
/api/auth/token
Cons to
/api/auth/token
:/api/auth/token
, Django (web+admin), OAuth/OIDC-ish)Two ways to move forward:
Authentication Proxy Server
app and client uses a authentication proxy server (authproxy) (have to check if this is secure) with Resource-Owner Password (ROP) flow. authproxy is required to make OAuth client confidential.
Pros:
Cons:
Migrate to OIDC
app and client migrates to OIDC (no ROP flow)
Pros:
Cons:
The text was updated successfully, but these errors were encountered: