-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: logform v2.7.0 breaks usages of its types without being a major version #336
Comments
Same issue also on our codebase (but function printf instead of format) |
yes, it's 55f3d8c changing |
Issue also with changing |
Same problem at my org. Is there actually anyone objecting to 'fixing' this in a new semver minor? Curious if there's consensus. Thanks all! |
Please fix this. |
The problem
Code that uses
logform
types (in my case a custom Winston formatter) and previously passed type-checking in logform 2.6.1 can in some cases no longer pass type-checking with logform 2.7.0, because usages ofany
were replaced withunknown
. #325 was a good change, but it should have been made in a major release oflogform
, whichwinston-transport
andwinston
should not have updated to without bumping their major versions as well.#325 should be reverted and postponed until logform 4.0.
What version of Logform presents the issue?
2.7.0
What version of Node are you using?
v20.18.0
If this is a TypeScript issue, what version of TypeScript are you using?
v5.5.4
If this worked in a previous version of Logform, which was it?
2.6.1
Minimum Working Example
Additional information
No response
🔎 Search Terms
typescript, unknown, any, breaking change
The text was updated successfully, but these errors were encountered: