Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-1041 jakarta-api-to-quarkus groovy rules #1051

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy added Ready to Review auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch labels Jan 12, 2024
@PhilipCattanach PhilipCattanach added the auto-backport Set the PR for being backported label Jan 12, 2024
return matchesProject
}

ruleSet("javaee-api-to-quarkus-groovy")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should reflect the filename, so jakarta- not java-

}

ruleSet("javaee-api-to-quarkus-groovy")
.addSourceTechnology(new TechnologyReference("jakarta", null))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the source to java-ee just to be consistent with the target/source folder structure (quarkus/java-ee).
Also jakarta isn't a valid source technology, jakarta-ee is. The --listSourceTechnologies option for the CLi will confirm this.

@PhilipCattanach
Copy link
Contributor

@m-brophy

I noticed some of the automated tests are failing
Failed tests:
2024-01-15T10:52:13.7682736Z WindupRulesTest.testWindupRules:155
2024-01-15T10:52:13.7683565Z Error with test: javaee-pom-to-quarkus-00000-test
2024-01-15T10:52:13.7685490Z Cause: (Rule: javaee-pom-to-quarkus-00000-test) Assertion failed: [javaee-pom-to-quarkus-00000] The project artifact's extension hint was not found!
2024-01-15T10:52:13.7686259Z
2024-01-15T10:52:13.7686486Z Error with test: javaee-pom-to-quarkus-00010-test
2024-01-15T10:52:13.7687396Z Cause: (Rule: javaee-pom-to-quarkus-00010-test) Assertion failed: [javaee-pom-to-quarkus-00010] Quarkus BOM hint was not found!
2024-01-15T10:52:13.7688019Z
2024-01-15T10:52:13.7688230Z Error with test: javaee-pom-to-quarkus-00020-test
2024-01-15T10:52:13.7689184Z Cause: (Rule: javaee-pom-to-quarkus-00020-test) Assertion failed: [javaee-pom-to-quarkus-00020] Quarkus Maven plugin hint was not found!
2024-01-15T10:52:13.7689848Z
2024-01-15T10:52:13.7690057Z Error with test: javaee-pom-to-quarkus-00030-test
2024-01-15T10:52:13.7690967Z Cause: (Rule: javaee-pom-to-quarkus-00030-test) Assertion failed: [javaee-pom-to-quarkus-00030] Maven Compiler plugin hint was not found!
2024-01-15T10:52:13.7691625Z
2024-01-15T10:52:13.7691835Z Error with test: javaee-pom-to-quarkus-00040-test
2024-01-15T10:52:13.7693030Z Cause: (Rule: javaee-pom-to-quarkus-00040-test) Assertion failed: [javaee-pom-to-quarkus-00040] Maven Surefire plugin hint was not found!
2024-01-15T10:52:13.7693735Z
2024-01-15T10:52:13.7693958Z Error with test: javaee-pom-to-quarkus-00050-test
2024-01-15T10:52:13.7694878Z Cause: (Rule: javaee-pom-to-quarkus-00050-test) Assertion failed: [javaee-pom-to-quarkus-00050] Maven Failsafe plugin hint was not found!
2024-01-15T10:52:13.7695542Z
2024-01-15T10:52:13.7695749Z Error with test: javaee-pom-to-quarkus-00060-test
2024-01-15T10:52:13.7696689Z Cause: (Rule: javaee-pom-to-quarkus-00060-test) Assertion failed: [javaee-pom-to-quarkus-00060] Quarkus native profile hint was not found!

@PhilipCattanach
Copy link
Contributor

Reviewed and tested successfully.

@PhilipCattanach
Copy link
Contributor

All good - Thanks @m-brophy

@PhilipCattanach PhilipCattanach merged commit fa0bfa5 into windup:master Jan 16, 2024
26 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
* jakarta-api-to-quarkus groovy rules

* source tag and ruleset naming changes

* misnaming corrected

* update number of test iterations because of new pom.xml file

(cherry picked from commit fa0bfa5)
Copy link

💚 All backports created successfully

Status Branch Result
releases/6.3.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request Jan 17, 2024
* jakarta-api-to-quarkus groovy rules

* source tag and ruleset naming changes

* misnaming corrected

* update number of test iterations because of new pom.xml file

(cherry picked from commit fa0bfa5)

Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
Co-authored-by: Phil Cattanach <31246010+PhilipCattanach@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants