-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WINDUPRULE-1041 jakarta-api-to-quarkus groovy rules #1051
Conversation
return matchesProject | ||
} | ||
|
||
ruleSet("javaee-api-to-quarkus-groovy") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should reflect the filename, so jakarta- not java-
} | ||
|
||
ruleSet("javaee-api-to-quarkus-groovy") | ||
.addSourceTechnology(new TechnologyReference("jakarta", null)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the source to java-ee just to be consistent with the target/source folder structure (quarkus/java-ee).
Also jakarta isn't a valid source technology, jakarta-ee is. The --listSourceTechnologies option for the CLi will confirm this.
I noticed some of the automated tests are failing |
Reviewed and tested successfully. |
All good - Thanks @m-brophy |
* jakarta-api-to-quarkus groovy rules * source tag and ruleset naming changes * misnaming corrected * update number of test iterations because of new pom.xml file (cherry picked from commit fa0bfa5)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
* jakarta-api-to-quarkus groovy rules * source tag and ruleset naming changes * misnaming corrected * update number of test iterations because of new pom.xml file (cherry picked from commit fa0bfa5) Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com> Co-authored-by: Phil Cattanach <31246010+PhilipCattanach@users.noreply.github.com>
WINDUP-1041