Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUPRULE-1018: new ruleset for eap8 log4j removed #1016

Merged
merged 7 commits into from
Sep 5, 2023
Merged

WINDUPRULE-1018: new ruleset for eap8 log4j removed #1016

merged 7 commits into from
Sep 5, 2023

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy commented Aug 3, 2023 •
edited
Loading

https://issues.redhat.com/browse/WINDUPRULE-1018

mvn clean test -DrunTestsMatching=log4j-removed

@m-brophy m-brophy requested review from PhilipCattanach and jmle and removed request for PhilipCattanach August 3, 2023 10:47
@PhilipCattanach
Copy link
Contributor

@m-brophy Thanks for the PR
The message for the first rule has a spelling mistake, and it is also reflected in the tests
Log4j usage without comfiguration files
Also the first rule, the logic has back to back not statements, shouldn't they be joined by an and
It seems to work but the logic is no config files AND no log4j embedded artifact AND references to Log4J

@PhilipCattanach PhilipCattanach requested review from PhilipCattanach and removed request for jmle August 23, 2023 16:41
@mrizzi mrizzi added auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch labels Aug 24, 2023
@PhilipCattanach
Copy link
Contributor

@m-brophy - The rules look fine.
Only 1 thing that needs to change is the Ruleset description, It currently reads:

This ruleset provides analysis of Java EE applications that need to change their configuration to migrate from Keycloak to native EAP OpenID Connect support

If you can update that then I'll merge to master

@PhilipCattanach
Copy link
Contributor

Tested successfully locally.

@PhilipCattanach PhilipCattanach merged commit 4c2e12d into windup:master Sep 5, 2023
24 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
@m-brophy
WINDUPRULE-1018: new ruleset for eap8 log4j removed (#1016)
9d89967 
* WINDUPRULE-1018: new ruleset for eap8 log4j removed

* fix typo and logic error in rule 00001

* alter ruleset description

---------

Co-authored-by: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com>
(cherry picked from commit 4c2e12d)
@github-actions github-actions bot mentioned this pull request Sep 5, 2023
Merged
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

💚 All backports created successfully

Status Branch Result
✅ releases/6.3.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request Sep 19, 2023
@github-actions @m-brophy
WINDUPRULE-1018: new ruleset for eap8 log4j removed (#1016) (#1025)
656723b 
* WINDUPRULE-1018: new ruleset for eap8 log4j removed

* fix typo and logic error in rule 00001

* alter ruleset description

---------

Co-authored-by: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com>
(cherry picked from commit 4c2e12d)

Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipCattanach PhilipCattanach Awaiting requested review from PhilipCattanach

Assignees
No one assigned
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch Ready to Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-brophy @PhilipCattanach @mrizzi