Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be (semi)official #5

Open
majiang opened this issue Mar 3, 2019 · 5 comments
Open

Be (semi)official #5

majiang opened this issue Mar 3, 2019 · 5 comments

Comments

@majiang
Copy link

majiang commented Mar 3, 2019

Official D Download page points dlanguage/dmd in DockerHub, but dlang2/dmd-circleci here seems better maintained. Is there any plans PR to dlang.org to point this, or even make this official?

@wilzbach
Copy link
Owner

wilzbach commented Mar 3, 2019

Well, just make a PR to dlang.org and then I think we can easily change the link. I'm aware of the unmaintained dlanguage packages too.
Well, ideally we should move these scripts to one of the main repositories, s.t. they can get the automated DockerHub builds and there doesn't need to be this nightly cron job approach.

I looked once into making official D docker images for Docker Hub and IIRC that would require a lot of work as they require each release to be signed and basically have someone on call if anything breaks. Also, in most of my use cases I just use a Busybox docker image as base image and then copy the binary into the container.

The main reason this repo exists is because the docker images that CircleCI shipped had a broken libc, thus we needed our own CircleCI image for DMD. I haven't checked for a while if the issue still exists, but presumably this is fixed now and the only advantage is that we save the ten seconds of downloading the DMD binaries with the installer script (though in sum we probably loose time because our DMD image is not very popular and thus not in the cache of many of their workers and needs to be downloaded every time).

@wilzbach
Copy link
Owner

wilzbach commented Dec 2, 2019

BTW if people felt more comfortable with this being in dlang-community, I would be open to moving it there.

CC @andre2007 @skoppe

@skoppe
Copy link
Contributor

skoppe commented Dec 2, 2019

I don't mind either way. I am using them daily myself.

+1 for updating the link on the download page.

@dgellow
Copy link

dgellow commented Apr 30, 2020

It looks like the download page has been updated
image

(that's from current https://dlang.org/download.html)

@dgellow
Copy link

dgellow commented Apr 30, 2020

Regarding having an official docker image, the process is described here: https://docs.docker.com/docker-hub/official_images/#creating-an-official-image.

And more details in the two dedicated github repositories (mentioned in the above link):

I don't think that I understand the full process, but from what I get it would be enough to create a Pull Request or just an issue on both repositories with an official image, and see how it goes from there?

I haven't found anything regarding the need for an on-call person, @wilzbach is that an information you got from the docker team? If yes, what does that imply exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants