-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate original source of data (and via what aggregator) #40
Comments
Related: #39. |
I would only change this to be |
Works for me :) |
Seems like most the above applies to the To give credit to our All need to print out in a section under https://github.com/whosonfirst/whosonfirst-sources/blob/master/sources/README.md#quattroshapes After
With bullet points listed below, alphabetically eg:
And that list needs to be from a new JSON list in the quattroshapes.json source. Ideally it could contain HTML text with hyperlinks (?) since I think we had problems with Markdown before. |
The textual description part of this here in the sources repo is done. Leaving this issue open as there is related work to followup about. |
For this county in Tanzania: Let's pretend it has the following properties:
We want to track generically the sources sources in predictable machine readable way, and in a way that doesn't need constant shuffling around as default and alt geoms are shuffled around, and without adding more sources JSONs, and making use of the existing NOTE: This new property would only be added in cases of WOF records where multiple sources exist for a source (eg Mesoshapes, Quattroshapes, and other *shapes sources), then all sources would be listed out in the extended format. Else no change if not multiple source sources. We propose to add a new "
Another example:
Then in the sources repo (this repo), modify the meso.json:
From: "src:via" : {
"context": "Tanzania",
"source_link": "",
"source_name": "Tanzania National Bureau of Statistics (TNBS)",
"source_note": ""
}, Add: "source_code": "tza_tnbs" "src:via" : {
"context": "Tanzania",
"source_link": "",
"source_name": "Tanzania National Bureau of Statistics (TNBS)",
"source_code": "tza_tnbs",
"source_note": ""
}, |
Does this need to be a different structure? "src_via:geom"={
"meso":[
"tza_tnbs"
],
"naturalearth":[
"naturalearth"
],
"quattroshapes":[
"statscan"
]
} And should we riff on |
@nvkelso - the example in #40 (comment) makes more sense. |
Flagging @thisisaaronland for comments. We'd like to make this change next week. |
With regards to the Likewise I would consider changing all the
Like why wouldn't it just be:
|
👍
That's because some sources include multiple sources so they need to be lists of lists. |
Okay. |
|
Right now we have data from Quattroshapes which is actually originates from multiple difference sources. Each source needs to be credited, so we need a consistent WOF property to deal with this.
I propose a new property like
src:via
(wassrc_via
originally) where thesrc
should state the original source, and then we should credit the data aggregator insrc:via
as well.Examples:
"qs:source"
value of"AUS Census"
(should just be US Census, oops) and"src:geom"
ofquattroshapes
."src:geom"
should beuscensus
instead, with"src_via"
set toquattroshapes
"meso:source"
value of"EDP"
, though no EDP.json file is currently in the sources folder."src:geom"
should beeep
instead, with"src_via"
set tomeso
The text was updated successfully, but these errors were encountered: