-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Rename integer types to match ECMAScript typed arrays #1030
base: main
Are you sure you want to change the base?
Conversation
c3318b7
to
791f0a3
Compare
791f0a3
to
e7f7140
Compare
Seeing new activity on this, I'm curious if this change is a sure thing - i.e. is this renaming settled and there's just remaining work to do to get everything aligned, or is it still an open question? (I think these are positive changes - even though I've grown kinda of fond of the quirky old names. My interest stems from maintaining some Web IDL tools that will need to be updated to account for this.) |
I don't believe anyone is pursuing this except @ExE-Boss. |
I think this is a good change if we can pull it off, with regards to the tooling and downstream review impact. |
e7f7140
to
cc2c100
Compare
I also like this since this fits better with modern C++ integer names and most of implementations are in C++ (with an exception of Servo but it also better matches Rust names). |
cc2c100
to
e5d51fa
Compare
e5d51fa
to
c06acfc
Compare
04346ea
to
d71765b
Compare
Thanks for removing the pseudo IDL blocks but I mean the aliases are probably not needed at all, and parsers can support both in the reasonably short term while @autokagami sends patches. It does depend on how quickly maintainers will respond (and plus, on whether other people here are convinced), though. |
Co-authored-by: Darien Maillet Valentine <valentinium@gmail.com>
d71765b
to
a1e472b
Compare
I’ve separated out the integer types rename from #856, as it has greater support and can be done without waiting for parser changes (see also #477).
This renames the integer types to match ECMAScript typed arrays in order to resolve the conflict between the Infra byte and the IDL
byte
; refs #843 (comment):Floating‑point types were left for a future PR because it’s not possible to simply rename
unrestricted float
/unrestricted double
tounrestricted float32
/unrestricted float64
without the parser being updated first, which is why that depends on something like #857.I decided to go with
int*
for signed integers since it’s what ECMAScript typed arrays use, and because ECMAScript provides built‑in support for 32‑bit signed integers using the bitwise OR operator, but none for unsigned integers:ECMAScript
Array
s also restrict the length to a positive 32‑bit signed integer.(See WHATWG Working Mode: Changes for more details.)
Preview | Diff
Preview | Diff