Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine and Evaluate Type of Attribute Input Value #13

Open
wesleyboar-fka-iosulfur opened this issue Oct 17, 2019 · 0 comments
Open

Comments

@wesleyboar-fka-iosulfur
Copy link
Collaborator

wesleyboar-fka-iosulfur commented Oct 17, 2019

The output.c-attr-input__value is given a class based on whether the numeric value of input.c-attr-input__field is positive or negative, but the value is typecast by assumption. See:

Instead, there should be a shared function that checks type of input. If type is number or range, only then should code set/assign class according to numeric value.

Known Issues

Potential Issues

@wesleyboar-fka-iosulfur wesleyboar-fka-iosulfur changed the title Determine and Evaluate Format of Attribute Input Value Determine and Evaluate Type of Attribute Input Value Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant