You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The output.c-attr-input__value is given a class based on whether the numeric value of input.c-attr-input__field is positive or negative, but the value is typecast by assumption. See:
Instead, there should be a shared function that checks type of input. If type is number or range, only then should code set/assign class according to numeric value.
if output of AttributeInput were not numeric, then it would receive irrelevant is-positive|negative class
The text was updated successfully, but these errors were encountered:
wesleyboar-fka-iosulfur
changed the title
Determine and Evaluate Format of Attribute Input Value
Determine and Evaluate Type of Attribute Input Value
Oct 17, 2019
The
output.c-attr-input__value
is given a class based on whether the numeric value ofinput.c-attr-input__field
is positive or negative, but the value is typecast by assumption. See:plain
implementation's blind use ofassignClassFromValue
react
implementation's blind use ofsetSignClassName
Instead, there should be a shared function that checks type of input. If type is
number
orrange
, only then should code set/assign class according to numeric value.Known Issues
plain
markupdata-output-for="card-ident-element"
receives irrelevantis-positive|negative
classPotential Issues
output
ofAttributeInput
were not numeric, then it would receive irrelevantis-positive|negative
classThe text was updated successfully, but these errors were encountered: