Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: autocomplete (rebase) #4327

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

feat: autocomplete (rebase) #4327

wants to merge 18 commits into from

Conversation

HyperDanisH
Copy link

What kind of change does this PR introduce?
feature #1402

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

@HyperDanisH HyperDanisH requested a review from a team as a code owner November 16, 2024 17:46
@HyperDanisH
Copy link
Author

HyperDanisH commented Nov 16, 2024 •
edited
Loading

Here is the rebase version an existing pull request I had made regarding autocomplete feature as said by sir @evenstensberg. Had to close the previous pr. I would love to take on this issue again if possible.

Best.

@evenstensberg
Copy link
Member

There's still conflicts

evenstensberg
evenstensberg reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. We're going to review this pr multiple times. When we suggest a change, do the change and then we iterate.

Thanks for your contribution! <3

packages/webpack-cli/src/utils/autocomplete.ts
@@ -0,0 +1,152 @@
import * as Fs from "fs";

// eslint-disable-next-line @typescript-eslint/no-var-requires
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be removed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it.

packages/webpack-cli/src/utils/autocomplete.ts Show resolved Hide resolved
@HyperDanisH
Copy link
Author

Super. We're going to review this pr multiple times. When we suggest a change, do the change and then we iterate.

Thanks for your contribution! <3

I think there is some work still pending, one important thing is to find a way to fetch list of all the commands supported by webpack-cli to display on auto complete. I'm ready to take on this issue once again but this issue still I can't figure out how to fix.

@evenstensberg
Copy link
Member

Could you create a todo in the pr description so we can see what you think is missing?

@HyperDanisH
Copy link
Author

I'll update you soon

alexander-akait
alexander-akait reviewed Nov 28, 2024
View reviewed changes
packages/webpack-cli/src/webpack-cli.ts
} else if (isCommand(commandName, getKnownCommand("setup-autocomplete"))) {
this.makeCommand(getKnownCommand("setup-autocomplete"), [], async () => {
await this.setupAutocompleteForShell();
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use commander api here, get all commands and options and run setupAutocompleteForShell with them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenstensberg evenstensberg evenstensberg left review comments

@alexander-akait alexander-akait alexander-akait left review comments

@anshumanv anshumanv Awaiting requested review from anshumanv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HyperDanisH @evenstensberg @alexander-akait @webpack-bot