feat: support regex in filter #1555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes running css-loader with advanced filter settings in worker possible.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1555 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 10 10
Lines 1185 1187 +2
Branches 456 457 +1
=======================================
+ Hits 1135 1137 +2
Misses 41 41
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes running css-loader with advanced filter settings in worker possible.
This PR contains a:
Motivation / Use-Case
For thread-loader, setting functions as options is not allowed yet, but regex is. Therefore, supporting regex as a filter option for css-loader enables us to use the loader parallelized.
Breaking Changes
Additional Info