-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTC fixes #14
base: master
Are you sure you want to change the base?
UTC fixes #14
Conversation
Although webdigi#13 removed some troubling code, there still seems to be an issue where SugarJS is maintaining the timezone of the user and mixing it up with the time zone of the server (it seems). Forcing the GmailScheduler script to use UTC is the sane solution to dealing with people in different time zones. HOWEVER, before merging this pull request, I highly recommend you create a new Google Apps Script project and transfer your current project there to use as a test project. Put this code in that new Google Apps Script project, which will serve as a sandbox. Then enable me (or anyone else in a different timezone as you) to test the script by checking the Log window in Google Apps' script editor.
Upon further inspection, this may be the culprit: Meaning we will need to manually calculate the timezone offset from the UTC and then do some math before showing the user a time. |
@thapar - Please upload https://github.com/webdigi/GmailScheduler/tree/master/src under your account. We can then test that fully under the account you create. Since you are an active contributor it might be best if you have a separate working copy in your google scripts account. |
I do have a working copy. But it doesn't help me to test since I'm in my On Thu, Feb 26, 2015 at 3:26 AM, Webdigi - Web Development <
|
Yes, understood. |
Changing that timezone changes the whole timezone in use, so that doesn't On Thu, Feb 26, 2015 at 3:43 AM, Webdigi - Web Development <
|
Although #13 removed some troubling code, there still seems to be an issue where SugarJS is maintaining the timezone of the user and mixing it up with the time zone of the server (it seems). Forcing the GmailScheduler script to use UTC is the sane solution to dealing with people in different time zones.
HOWEVER, before merging this pull request, I highly recommend you create a new Google Apps Script project and transfer your current project there to use as a test project. Put this code in that new Google Apps Script project, which will serve as a sandbox. Then enable me (or anyone else in a different timezone as you) to test the script by checking the Log window in Google Apps' script editor.