-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve language packs depending on requested version #140
Comments
Should we try to expose all possible versions via the API? |
Good point. Only the latest version which match the requested version actually. Examples: https://api.wordpress.org/translations/themes/1.0/?slug=twentyseventeen&version=1.0 (only 1.0) |
That means we should make the version number a part of the file name or put them into folders like on WordPress.org. The latter is probably easier Either way, I think we should add a CLI command to remove old files that can be run when upgrading. It would basically do half of what |
We could extend For running the complete uninstall routine there is |
Hmm, sounds like we need to store a list of language packs per project in gp_meta or something. Otherwise we have no idea what kind of files there are on the server. |
Issue Overview
Since #133 the version of the theme/plugin is used for the version field in the API. But the actual download URL is still the same for all versions.
Expected behavior
The path to the language pack includes the version of the language pack.
Additional context
WP.org API: https://api.wordpress.org/translations/themes/1.0/?slug=twentynineteen
The text was updated successfully, but these errors were encountered: