Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: allow users to build their own set of rules #45

Closed
roaldnefs opened this issue Oct 12, 2019 · 3 comments · Fixed by #52
Closed

Feature Request: allow users to build their own set of rules #45

roaldnefs opened this issue Oct 12, 2019 · 3 comments · Fixed by #52
Assignees
Labels

Comments

@roaldnefs
Copy link
Member

Preface

Repost of a discussion from Slack: https://github.com/roaldnefs/salt-lint/issues/19#issuecomment-541280250.

Description

Allow the user to specify additional/custom rules when running salt-lint. ansible-lint also includes such a option, which could serve as an example because this project is based upon the ansible-lint project:

  -r RULESDIR           specify one or more rules directories using one or
                        more -r arguments. Any -r flags override the default
                        rules in ['/path/to/ansible-
                        lint/lib/ansiblelint/rules'], unless -R is also used.
  -R                    Use default rules ['/path/to/ansible-
                        lint/lib/ansiblelint/rules'] in addition to any extra
                        rules directories specified with -r. There is no need
                        to specify this if no -r flags are used
@roaldnefs roaldnefs added Type: Enhancement New feature or request Hacktoberfest labels Oct 12, 2019
@Joel-hanson
Copy link
Contributor

Shall I take this up @roaldnefs .

@roaldnefs
Copy link
Member Author

Thanks @Joel-hanson for the quick response! I've assigned you to this issue.

@Joel-hanson
Copy link
Contributor

Hi @roaldnefs ,

I have made a pull request #52 . Hope it solves this issue.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants