-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Implement yamllint rules #240
Comments
any news on that? |
Hi @colttt ! It's not as easy as simply adding yamllint. But for now we don't have a status update sadly. Feel free to use our container image for salt-lint and add yamllint yourself though. Or implement a new step in your CI where you run yamllint on all sls files. Though be prepared for a whole lot of false positives. |
I got:
|
It's a hardened image. You can't just add stuff to the container itself. Fork the Dockerfile and build it yourself. |
Is your feature request related to a problem? Please describe.
Allow running the same rules as yamllint on SLS files to check for issues such as indentation, etc.
Describe the solution you'd like
Add rule to run yamllint on SLS files after stripping all Jinja expressions, statements and comments. See the YamlLintRule in ansible-lint as an example.
Describe alternatives you've considered
Re-implementing all the yamllint rules separately.
Additional context
This feature request duplicates #106, #105, #92.
The text was updated successfully, but these errors were encountered: