Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrict Mode not removing roles #68

Open
SimplyUnnamed opened this issue Sep 19, 2021 · 0 comments
Open

Scrict Mode not removing roles #68

SimplyUnnamed opened this issue Sep 19, 2021 · 0 comments

Comments

@SimplyUnnamed
Copy link
Contributor

SimplyUnnamed commented Sep 19, 2021

Think I found a glitch where strict mode is not removing roles when invalid tokens crop up.

I think I found it issue is here

public function areAllTokensValid(): bool

i think should be using

$user->all_characters->count()

Doesn't look like the 'softDeleted' scope is being ignored here.

Since characters is fetched through the RefreshToken model as well, it is comparing valid tokens to valid tokens.

il try to do up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant