Fix/scrolling contents #520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed unused layer height methods
|
Hi, this fix does solve the scrolling error, but introduces a new problem: error.movError not in #521 |
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
Fixes wagoodman#469 Fixes wagoodman#494 Fixes wagoodman#540 Refs wagoodman#473 Refs wagoodman#478 Refs wagoodman#520 Co-authored-by: st-gr <38470677+st-gr@users.noreply.github.com>
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
Fixes wagoodman#469 Fixes wagoodman#494 Fixes wagoodman#540 Refs wagoodman#473 Refs wagoodman#478 Refs wagoodman#520 Co-authored-by: st-gr <38470677+st-gr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to pull request #473
This should fix the
static-analysisfailures in the pipeline.I am not good at re-base, so opted to merge main into this branch to check if @mark2185's fix plays well with the current version of dive. Tested to work locally.