-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event payload filtering #176
Comments
The current draft describes the first way. But this is confusing when considering what JSONPath and XPath are really meant for. Going to make a PR to remove that for now: #177. |
Remove payload-based event filtering. Note this only comments out the section, we can revert this easily if desired. Related issue (#176) is to figure out how to do this properly so will remain open.
Thank you for creating the issue 👍🏻 and I agree that selecting while also filtering events is tricky. I just want to clarify a point. The use case in point 1 I slightly narrowed with respect to what we had in mind. It would be nice to have the ability to subscribe to facts about the whole collection of TDs, not just a specific one. Like with Do you think is still confusing? |
I fully understand your point and have also thought about applying the expression to a hypothetical list, but this is really a hack to make JSONPath work. I particularly didn't pursue that approach for the following reasons:
I personally think the best use of JSONPath in events is to filter and select parts of data from individual events (bullet number 2 above). Assertions on TD attributes can still be done on the client side. |
The Notification API draft describes filtering of events based on their types.
The filtering based on payload was suggested by in #28 (comment). But there are different filtering requirements:
$.properties
will trigger event when properties change.$.properties
will only give events with properties values.$.properties
will give only the changed properties.Notes:
The text was updated successfully, but these errors were encountered: